C++: Update for changes in frontend. #14135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashabu
force-pushed
the
sashabu/frontend-update
branch
from
511dadc to
aab35ea
Compare
sashabu
force-pushed
the
sashabu/frontend-update
branch
from
aab35ea to
f6122a6
Compare
sashabu
force-pushed
the
sashabu/frontend-update
branch
from
fdc0217 to
6f5ac8d
Compare
sashabu
commented
Sep 5, 2023
...perimental/query-tests/Security/CWE/CWE-193/constant-size/ConstantSizeArrayOffByOne.expected
Show resolved
Hide resolved
sashabu
commented
Sep 5, 2023
cpp/ql/test/query-tests/Security/CWE/CWE-193/InvalidPointerDeref.expected
Outdated
Show resolved
Hide resolved
jketema
force-pushed
the
sashabu/frontend-update
branch
2 times, most recently
from
97c2451 to
1baf1e1
Compare
jketema
reviewed
Sep 25, 2023
jketema
force-pushed
the
sashabu/frontend-update
branch
4 times, most recently
from
46e29a5 to
cb5bd4d
Compare
jketema
force-pushed
the
sashabu/frontend-update
branch
4 times, most recently
from
2c7c537 to
93d60be
Compare
These are due to additional loads being generated on fields, and should not cause any problems. Ideally, we should tune the definition of `TPostFieldUpdateNode` to make these go away.
The previous extractor options no longer work, because the default assumed compiler versions have changed in the frontend.
The IR now contains extra loads that need to be accounted for.
jketema
force-pushed
the
sashabu/frontend-update
branch
from
93d60be to
a972d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #13716 (which uses a personal fork instead of a branch on
github/codeql) so that I can take over while @jketema is out.