Repository navigation
fix(connectivity): catalog ModelConfigs inherit the platform maxTokens - #712
Merged
Merged
Conversation
Published Helm chart
|
| Chart | agent-platform |
| Version | 4.84.1-r79a95826t20260926153617ha980ae9 |
| OCI reference | oci://gsoci.azurecr.io/charts/giantswarm/agent-platform:4.84.1-r79a95826t20260926153617ha980ae9 |
| Digest | sha256:90d8a01e01b2318d5aec4759b4994c49eba048ba66c94ca04c7678df768e1a1d |
| Registry | public — gsoci.azurecr.io |
| Git catalog | giantswarm-test-catalog (index) |
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/agent-platform --version 4.84.1-r79a95826t20260926153617ha980ae9Posted by architect-orb · build 14938 · commit a980ae9 · updated in place on every push
Published Helm chart
|
| Chart | agent-platform-connectivity |
| Version | 4.84.1-r79a95826t20260926153617ha980ae9 |
| OCI reference | oci://gsoci.azurecr.io/charts/giantswarm/agent-platform-connectivity:4.84.1-r79a95826t20260926153617ha980ae9 |
| Digest | sha256:5ca6ea2dbe54519752f1441f5bc788841a9e6d0bf35e04d82d90563918d97a15 |
| Registry | public — gsoci.azurecr.io |
| Git catalog | giantswarm-test-catalog (index) |
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/agent-platform-connectivity --version 4.84.1-r79a95826t20260926153617ha980ae9Posted by architect-orb · build 14937 · commit a980ae9 · updated in place on every push
Member
Author
|
From Timo's agent: agentlab proof on this branch ( The API server admitted the inherited |
…okens * origin/main: feat(connectivity): retire the model-manager REST route (#711) feat(model-serving): gemma-4-31b at 32k with an fp8 KV cache (#709) feat(model-serving): the muse-glimmer-30b preset on vLLM's own image (#673) fix(model-serving): gpt-oss reads its tiktoken encodings from the image (#675) fix(hooks): serving teardown retries once Flux's API is gone (#707) feat(cluster-manager): provider aws opens the CAPA API server LBs (#704) # Conflicts: # CHANGELOG.md
Closed
3 tasks
teemow
added a commit
that referenced
this pull request
Sep 26, 2026
…n-post-delete * origin/main: fix(connectivity): catalog ModelConfigs inherit the platform maxTokens (#712) feat(connectivity): retire the model-manager REST route (#711) feat(model-serving): gemma-4-31b at 32k with an fp8 KV cache (#709) feat(model-serving): the muse-glimmer-30b preset on vLLM's own image (#673) fix(model-serving): gpt-oss reads its tiktoken encodings from the image (#675) fix(hooks): serving teardown retries once Flux's API is gone (#707) feat(cluster-manager): provider aws opens the CAPA API server LBs (#704) Signed-off-by: Timo Derstappen <teemow@gmail.com> # Conflicts: # CHANGELOG.md
teemow
added a commit
that referenced
this pull request
Sep 26, 2026
…se-placement * origin/main: fix(hooks): the bundled engine goes after Helm's delete pass (#713) fix(connectivity): catalog ModelConfigs inherit the platform maxTokens (#712) feat(connectivity): retire the model-manager REST route (#711) feat(model-serving): gemma-4-31b at 32k with an fp8 KV cache (#709) feat(model-serving): the muse-glimmer-30b preset on vLLM's own image (#673) # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #702.
Problem
A
kagent.modelConfigs[]entry of the connectivity chart renders nomaxTokens, so an agent on a catalog model (anthropic-opus-5,anthropic-opus-5-5) stops a long answer at kagent's built-in 8192 tokens, thinking included. The default ModelConfig has 32000: the platform manager setskagent.providers.anthropic.config.maxTokensfor every installation (giantswarm/giantswarm-platform-manager#206), and the connectivity release already receives that value; only the default ModelConfig used it.Change
kagent.providers.anthropic.config.maxTokensthe way it already inheritspromptCaching/cacheTTL, in the same provider block next to the listenerbaseUrl.maxTokenswins and lands in its provider's block (Anthropic, AnthropicVertexAI, AzureOpenAI, Mistral, OpenAI: the ModelConfigSpec blocks that have the field). On any other provider the render fails naming the entry, instead of the API server pruning it silently.make verify-max-tokensasserts inheritance, precedence, the no-default case and the guard.verify-kagent-crdsvalidates an entry withmaxTokensagainst the kagent line's CRD.No values change is needed on any installation: the four Opus agents get 32000 on the next rollout.
Verification
make verify-max-tokens verify-prompt-caching verify-llm-routing verify-kagent-crdspass locally.spec.anthropic.maxTokens: 32000, and a long Opus turn runs past 8192 tokens.