Repository navigation
fix(hooks): serving teardown retries once Flux's API is gone - #707
Merged
Merged
Conversation
3 tasks
Published Helm chart
|
| Chart | agent-platform |
| Version | 4.80.1-r2e419057t20260926071816hb919a06 |
| OCI reference | oci://gsoci.azurecr.io/charts/giantswarm/agent-platform:4.80.1-r2e419057t20260926071816hb919a06 |
| Digest | sha256:567743d822b892dbd2c73976f9ee15302bd86ecbc03b5f3f733e4f4e5ae47f58 |
| Registry | public — gsoci.azurecr.io |
| Git catalog | giantswarm-test-catalog (index) |
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/agent-platform --version 4.80.1-r2e419057t20260926071816hb919a06Posted by architect-orb · build 14637 · commit b919a06 · updated in place on every push
Published Helm chart
|
| Chart | agent-platform-connectivity |
| Version | 4.80.1-r2e419057t20260926071816hb919a06 |
| OCI reference | oci://gsoci.azurecr.io/charts/giantswarm/agent-platform-connectivity:4.80.1-r2e419057t20260926071816hb919a06 |
| Digest | sha256:dc16bf38ed38172bdc80d26e29e6e640af0e1df08deb4b273fc77ba55834dc8c |
| Registry | public — gsoci.azurecr.io |
| Git catalog | giantswarm-test-catalog (index) |
Pull this chart
helm pull oci://gsoci.azurecr.io/charts/giantswarm/agent-platform-connectivity --version 4.80.1-r2e419057t20260926071816hb919a06Posted by architect-orb · build 14638 · commit b919a06 · updated in place on every push
teemow
added a commit
that referenced
this pull request
Sep 26, 2026
…reset-597 * origin/main: fix(model-serving): gpt-oss reads its tiktoken encodings from the image (#675) fix(hooks): serving teardown retries once Flux's API is gone (#707) feat(cluster-manager): provider aws opens the CAPA API server LBs (#704) feat: the kagent line at 1.2.0 with its SDK-spec OTel values (#693) # Conflicts: # CHANGELOG.md # tests/verify-gpu-pool.py
teemow
added a commit
that referenced
this pull request
Sep 26, 2026
…8-kv-611 * origin/main: feat(model-serving): the muse-glimmer-30b preset on vLLM's own image (#673) fix(model-serving): gpt-oss reads its tiktoken encodings from the image (#675) fix(hooks): serving teardown retries once Flux's API is gone (#707) feat(cluster-manager): provider aws opens the CAPA API server LBs (#704) feat: the kagent line at 1.2.0 with its SDK-spec OTel values (#693) # Conflicts: # README.md # tests/verify-gpu-pool.py
teemow
added a commit
that referenced
this pull request
Sep 26, 2026
…okens * origin/main: feat(connectivity): retire the model-manager REST route (#711) feat(model-serving): gemma-4-31b at 32k with an fp8 KV cache (#709) feat(model-serving): the muse-glimmer-30b preset on vLLM's own image (#673) fix(model-serving): gpt-oss reads its tiktoken encodings from the image (#675) fix(hooks): serving teardown retries once Flux's API is gone (#707) feat(cluster-manager): provider aws opens the CAPA API server LBs (#704) # Conflicts: # CHANGELOG.md
teemow
added a commit
that referenced
this pull request
Sep 26, 2026
…n-post-delete * origin/main: fix(connectivity): catalog ModelConfigs inherit the platform maxTokens (#712) feat(connectivity): retire the model-manager REST route (#711) feat(model-serving): gemma-4-31b at 32k with an fp8 KV cache (#709) feat(model-serving): the muse-glimmer-30b preset on vLLM's own image (#673) fix(model-serving): gpt-oss reads its tiktoken encodings from the image (#675) fix(hooks): serving teardown retries once Flux's API is gone (#707) feat(cluster-manager): provider aws opens the CAPA API server LBs (#704) Signed-off-by: Timo Derstappen <teemow@gmail.com> # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #527
Problem
The
<release>-serving-teardownhook (pre-delete) deletes thekserve-llmisvc-resourcesandkserve-runtime-configsHelmReleases unconditionally. With the bundled engine on, an uninstall that fails after the engine's teardown (it removes Flux, CRDs included) is retried with the hooks running again, and every attempt of the serving hook then fails:So a failed uninstall cannot be retried: the retry stops at this hook (
Job Failed. failed: 3/1).Change
The two child release deletes run only while Flux's HelmRelease CRD exists. Without it no child release is left to order, and the hook says so. The config step is unchanged: it still frees any config left with the llm-d finalizer.
make verify-serving-teardownadds the retry: with the HelmRelease API gone the script completes and deletes nothing.Proof
make verify-serving-teardown: the order, the storage-version requests, the idempotent re-run, and the new retry without the HelmRelease API.helm uninstall agent-platform. The serving hook ran in 8 s in cluster-manager's order: the controller's release deleted and its webhook gone, the ten configs deleted throughv1alpha2with the finalizer removed, thenkserve-runtime-configs. Afterwards there was nokserve-*HelmRelease, noLLMInferenceServiceConfig, no llmisvc webhook configuration and nokserve-*release Secret. The retry of the same uninstall then failed at this hook as shown above; that is what this PR fixes.The meta release's own uninstall failing in the bundled-engine shape (Helm can't build the release's HelmRelease and OCIRepository objects once Flux's CRDs are gone) is a separate defect, filed on its own.