Remove more internal uses of IDs #4 #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
force-pushed
the
remove-more-uses-of-ids-4
branch
from
c74f26a
to
c3d105a
Compare
nical
approved these changes
Jul 2, 2024
This gets the bind_group_layout_dedup test passing again.
Also removes label from `Element::Error` and slightly refactors ContextError.
The scope is already printed by the Display impl of those errors.
… `Element::Vacant`
teoxoy
force-pushed
the
remove-more-uses-of-ids-4
branch
from
c3d105a
to
f0d6ef9
Compare
This was referenced Jul 4, 2024
torokati44
added a commit
to torokati44/ruffle
that referenced
this pull request
Jul 19, 2024
Since wgpu has (temporarily) removed its `trace` feature. gfx-rs/wgpu#5975 gfx-rs/wgpu#5974 gfx-rs/wgpu#5897
torokati44
added a commit
to torokati44/ruffle
that referenced
this pull request
Jul 29, 2024
Since wgpu has (temporarily) removed its `trace` feature. gfx-rs/wgpu#5975 gfx-rs/wgpu#5974 gfx-rs/wgpu#5897
torokati44
added a commit
to torokati44/ruffle
that referenced
this pull request
Jul 31, 2024
Since wgpu has (temporarily) removed its `trace` feature. gfx-rs/wgpu#5975 gfx-rs/wgpu#5974 gfx-rs/wgpu#5897
torokati44
added a commit
to torokati44/ruffle
that referenced
this pull request
Aug 5, 2024
Since wgpu has (temporarily) removed its `trace` feature. gfx-rs/wgpu#5975 gfx-rs/wgpu#5974 gfx-rs/wgpu#5897
torokati44
added a commit
to torokati44/ruffle
that referenced
this pull request
Aug 5, 2024
Since wgpu has (temporarily) removed its `trace` feature. gfx-rs/wgpu#5975 gfx-rs/wgpu#5974 gfx-rs/wgpu#5897
torokati44
added a commit
to torokati44/ruffle
that referenced
this pull request
Aug 5, 2024
Since wgpu has (temporarily) removed its `trace` feature. gfx-rs/wgpu#5975 gfx-rs/wgpu#5974 gfx-rs/wgpu#5897
torokati44
added a commit
to torokati44/ruffle
that referenced
this pull request
Aug 5, 2024
Since wgpu has (temporarily) removed its `trace` feature. gfx-rs/wgpu#5975 gfx-rs/wgpu#5974 gfx-rs/wgpu#5897
Dinnerbone
pushed a commit
to ruffle-rs/ruffle
that referenced
this pull request
Aug 6, 2024
Since wgpu has (temporarily) removed its `trace` feature. gfx-rs/wgpu#5975 gfx-rs/wgpu#5974 gfx-rs/wgpu#5897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a regression in functionality: Compute/render pass end/finish won't be traced for
wgpuusers. To be able to completely remove the IDs held inside resources I had to move the tracing code to{compute,render}_pass_end_with_unresolved_commands. I will address this regression in a follow-up PR since it requires more changes to get it working again and this PR has been getting quite large.Part of #5121.
Fixes #5328.
Fixes #3790.
PR doesn't need to be squashed, each commit builds by itself.