Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline is not referred to by label in error message #3790

Closed
EriKWDev opened this issue May 21, 2023 · 0 comments · Fixed by #5897
Closed

Pipeline is not referred to by label in error message #3790

EriKWDev opened this issue May 21, 2023 · 0 comments · Fixed by #5897
Labels
kind: diagnostics Error message should be better

Comments

@EriKWDev
Copy link

EriKWDev commented May 21, 2023

Problem

Caused by:
    In a RenderPass
      note: encoder = `Common encoder`
    In a draw command, indexed:true indirect:false
      note: render pipeline = '<RenderPipeline-(8, 1, Vulkan)>'
    < error message ... >      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                               |
                               |____ ???

When using a CommandEncoder that encodes multiple different pipelines and drawcalls, if anything goes wrong I get a message like the one above^

The problem is that I have given all my render passes and pipeline's labels, but it still only refers to the pipelines as such: <RenderPipeline-(8, 1, Vulkan)>.

Desired outcome

It would be much easier to debug errors if the error message instead showed me the pipeline's label (or the renderpass's label or bindgroup's label or anything..) like how it already shows the encoder's label: Common encoder

I have given labels to everything xP Would be nice if I saw them more in error messages..

Extra info

wgpu = { version="0.16.0", features=["wgsl"] }

rustc 1.69.0 (84c898d65 2023-04-16)

The particular error message I got this time was The pipeline layout, associated with the current render pipeline, contains a bind group layout at index 0 which is incompatible with the bind group layout associated with the bind group at 0, but no matter the specific error it seems to not refer to the pipeline by its label either way.

@jimblandy jimblandy added the area: validation Issues related to validation, diagnostics, and error handling label Jun 8, 2023
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Jun 8, 2023
@teoxoy teoxoy added kind: diagnostics Error message should be better and removed area: validation Issues related to validation, diagnostics, and error handling labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: diagnostics Error message should be better
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants