Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more internal uses of IDs #4 #5897

Merged
merged 37 commits into from
Jul 2, 2024
Merged

Remove more internal uses of IDs #4 #5897

merged 37 commits into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. trace only compute_pass_end_with_unresolved_commands

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3971243 View commit details
    Browse the repository at this point in the history

  2. trace only render_pass_end_with_unresolved_commands

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    012d52a View commit details
    Browse the repository at this point in the history

  3. use .error_ident() for log::trace! in render_pass_end

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5894f98 View commit details
    Browse the repository at this point in the history

  4. remove PassErrorScope::PassEncoder and id arg of `PassErrorScope::P… 

    …ass`
    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e2ac725 View commit details
    Browse the repository at this point in the history

  5. remove ResourceInfo.id

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1fc8e44 View commit details
    Browse the repository at this point in the history

  6. introduce ResourceType trait

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ce03c71 View commit details
    Browse the repository at this point in the history

  7. introduce StorageItem trait

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    63b77d2 View commit details
    Browse the repository at this point in the history

  8. remove unused Resource bound

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d2f3549 View commit details
    Browse the repository at this point in the history

  9. introduce Labeled trait

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0c04881 View commit details
    Browse the repository at this point in the history

  10. introduce Trackable trait

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    61467e8 View commit details
    Browse the repository at this point in the history

  11. remove Resource trait

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ade94fc View commit details
    Browse the repository at this point in the history

  12. impl ParentDevice via macro

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    00b985c View commit details
    Browse the repository at this point in the history

  13. make Queue.device non-optional

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    487211f View commit details
    Browse the repository at this point in the history

  14. rename error variants that contain IDs

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    af2ff8b View commit details
    Browse the repository at this point in the history

  15. remove MissingCopyDstUsageFlag error variants

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9498319 View commit details
    Browse the repository at this point in the history

  16. use .check_usage() for QUERY_RESOLVE

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9e0c2c1 View commit details
    Browse the repository at this point in the history

  17. remove MissingCopySrcUsageFlag error variant

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    83a1fcc View commit details
    Browse the repository at this point in the history

  18. use ResourceErrorIdent in a few buffer error variants

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c8fee67 View commit details
    Browse the repository at this point in the history

  19. move the BGL compatibility check in the binder

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5a2c4f5 View commit details
    Browse the repository at this point in the history

  20. simplify the BGL compatibility check

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0bf43bf View commit details
    Browse the repository at this point in the history

  21. simplify logic of Entry.is_valid

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    34fdb80 View commit details
    Browse the repository at this point in the history

  22. introduce MultiError and use it for BGL incompatibility errors

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    df5de6e View commit details
    Browse the repository at this point in the history

  23. implement exclusive pipeline validation 

    This gets the bind_group_layout_dedup test passing again.
    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    fd9e4c8 View commit details
    Browse the repository at this point in the history

  24. remove label getters from Global 

    Also removes label from `Element::Error` and slightly refactors ContextError.
    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    eab4322 View commit details
    Browse the repository at this point in the history

  25. don't print the scope twice 

    The scope is already printed by the Display impl of those errors.
    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    20122a1 View commit details
    Browse the repository at this point in the history

  26. move ContextError's fmt logic in its Display impl

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    94ebbf5 View commit details
    Browse the repository at this point in the history

  27. remove PrettyError

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7a8e089 View commit details
    Browse the repository at this point in the history

  28. use Registry.get() instead of Registry.read().get_owned()

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    846d72b View commit details
    Browse the repository at this point in the history

  29. use Registry.get() for device_set_device_lost_closure

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8f2f2c0 View commit details
    Browse the repository at this point in the history

  30. remove Registry.try_get()

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    93da668 View commit details
    Browse the repository at this point in the history

  31. Panic on non-existent entry in Storage.get, this is consistent with… 

    … `Element::Vacant`
    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1c967c3 View commit details
    Browse the repository at this point in the history

  32. change Storage.force_replace to take an Arc<T>

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a70172f View commit details
    Browse the repository at this point in the history

  33. move out ID to BGL mapping from Device.create_pipeline_layout()

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9de2f5f View commit details
    Browse the repository at this point in the history

  34. assign resources/errors in the Global's pipeline creation functions

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1673ea9 View commit details
    Browse the repository at this point in the history

  35. move out ID to resource mapping code from pipeline creation methods

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d236661 View commit details
    Browse the repository at this point in the history

  36. move out ID to resource mapping code from Device.create_bind_group

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8c2fec1 View commit details
    Browse the repository at this point in the history

  37. gate fns behind either serde or replay since Firefox needs those

    @teoxoy
    teoxoy committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f0d6ef9 View commit details
    Browse the repository at this point in the history