Skip to content

fix(ui) Don't show save-org-search on event search #12785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Conversation

markstory
Copy link
Member

Use the hasPinnedSearch as a short term solution to hide the create saved search on the event search list. Very soon I'll be refactoring the input and button layouts.

Use the `hasPinnedSearch` as a short term solution to hide the create
saved search on the event search list. Very soon I'll be refactoring the
input and button layouts.
@markstory markstory requested a review from a team April 15, 2019 22:17
Copy link
Contributor

@mnoble mnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markstory markstory merged commit 96fd5b2 into master Apr 16, 2019
@markstory markstory deleted the fix-event-button branch April 16, 2019 01:23
jan-auer added a commit that referenced this pull request Apr 16, 2019
* master: (50 commits)
  fix(ui) Don't show save-org-search on event search (#12785)
  ref(ui): Remove some unnecessary index.jsx files (#12606)
  feat(app-platform): Analytics (#12718)
  ref(js): Remove ApiMixin (#12384)
  test(js): Silence project plugin console info spam (#12761)
  test(js): Move SaveSearchStore.reset() (#12769)
  test(js): Add more fields to Group fixture (#12759)
  feat(app-platform): Integration "Learn More" modal (#12638)
  feat(saved-searches) Move create saved search button to search bar. (#12781)
  ref(global-header): Remove dead code (#12767)
  ref(releases): Refactored Releases Serializers (#12535)
  feat(app-platform): Sort Integrations (#12697)
  ref(audit-log): Log sso config updates (#12744)
  ref(app-platform): New 'Open In' UI  (#12621)
  feat(events): Use SnubaEvent if option is turned on (#12594)
  feat(global-selection-header): show settings icon link in single project mode (#12772)
  refs(api): Consolidate all search backend code into `SnubaSearchBackend`
  fix(tests) Remove large snapshots (#12766)
  fix: Update symbolicator snapshots (#12710)
  ref: Upgrade semaphore (#12751)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants