ref(js): Remove ApiMixin [SEN-212] #12384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
force-pushed
the
ref/js/remove-api-mixin
branch
from
52739c9 to
2b9fcc4
Compare
|
@markstory tests are passing (there's a bunch of lint errors, but those should be easy to fix). Do we trust our test coverage? How should we handle this to limit risk and minimize efforts? |
Yes and no. I think the tests we have are good, but we don't have coverage on all these components. We could spend sometime manually ensuring there aren't any warnings/broken screens in staging as a way to reduce risk. |
billyvg
force-pushed
the
ref/js/remove-api-mixin
branch
from
8d528d9 to
15659b2
Compare
billyvg
changed the title
billyvg
force-pushed
the
ref/js/remove-api-mixin
branch
from
15659b2 to
66450f0
Compare
billyvg
force-pushed
the
ref/js/remove-api-mixin
branch
2 times, most recently
from
fa94a71 to
10b1843
Compare
|
A few of us clicked through this on staging the other day and it seems good |
evanpurkhiser
approved these changes
Apr 12, 2019
billyvg
force-pushed
the
ref/js/remove-api-mixin
branch
from
06bffdb to
29d69cd
Compare
billyvg
force-pushed
the
ref/js/remove-api-mixin
branch
from
29d69cd to
4498511
Compare
|
There's still a few more cases where my transforms didn't catch it, I'll probably update these manually |
jan-auer
added a commit
that referenced
this pull request
Apr 16, 2019
* master: (50 commits) fix(ui) Don't show save-org-search on event search (#12785) ref(ui): Remove some unnecessary index.jsx files (#12606) feat(app-platform): Analytics (#12718) ref(js): Remove ApiMixin (#12384) test(js): Silence project plugin console info spam (#12761) test(js): Move SaveSearchStore.reset() (#12769) test(js): Add more fields to Group fixture (#12759) feat(app-platform): Integration "Learn More" modal (#12638) feat(saved-searches) Move create saved search button to search bar. (#12781) ref(global-header): Remove dead code (#12767) ref(releases): Refactored Releases Serializers (#12535) feat(app-platform): Sort Integrations (#12697) ref(audit-log): Log sso config updates (#12744) ref(app-platform): New 'Open In' UI (#12621) feat(events): Use SnubaEvent if option is turned on (#12594) feat(global-selection-header): show settings icon link in single project mode (#12772) refs(api): Consolidate all search backend code into `SnubaSearchBackend` fix(tests) Remove large snapshots (#12766) fix: Update symbolicator snapshots (#12710) ref: Upgrade semaphore (#12751) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP -- tests either need to update snapshots and/or export the base component (because of enzyme and testing state, as well as shallow vs mount)
Relates to SEN-212