feat(app-platform): Integration "Learn More" modal #12638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnoble
force-pushed
the
app-platform/learn-more
branch
4 times, most recently
from
f43861a to
0bb7d0a
Compare
markstory
reviewed
Apr 4, 2019
src/sentry/static/sentry/app/components/modals/sentryAppDetailsModal.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/modals/sentryAppDetailsModal.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/modals/sentryAppDetailsModal.jsx
Outdated
Show resolved
Hide resolved
mnoble
force-pushed
the
app-platform/learn-more
branch
2 times, most recently
from
03de79f to
78151d3
Compare
MeredithAnya
reviewed
Apr 4, 2019
|
|
||
| return ( | ||
| <React.Fragment> | ||
| <Flex align="center" mb={2}> |
There was a problem hiding this comment.
I'm assuming this is copy-pasta from the other modals, but it seems weird that we have some inline styling and then some using the styled components. I feel like they should all be styled components
MeredithAnya
reviewed
Apr 8, 2019
| @@ -92,7 +92,7 @@ describe('Organization Developer Settings', function() { | |||
| body: [sentryApp], | |||
| }); | |||
| const wrapper = mount( | |||
| <OrganizationDeveloperSettings params={{orgId: newOrg.slug}} />, | |||
| <OrganizationDeveloperSettings params={{orgId: newOrg.slug}} organization={org} />, | |||
There was a problem hiding this comment.
should organization={org} be using the newOrg?
|
Can we add a test for the actual modal itself? Mainly to check if the button is disabled if the integration is already installed. |
mnoble
force-pushed
the
app-platform/learn-more
branch
from
78151d3 to
67169a1
Compare
MeredithAnya
approved these changes
Apr 10, 2019
mnoble
force-pushed
the
app-platform/learn-more
branch
5 times, most recently
from
7b57983 to
ce39698
Compare
Adds a modal for when the User clicks "Learn More" on the Integrations page, for a Sentry App.
mnoble
force-pushed
the
app-platform/learn-more
branch
from
ce39698 to
344a5cb
Compare
jan-auer
added a commit
that referenced
this pull request
Apr 16, 2019
* master: (50 commits) fix(ui) Don't show save-org-search on event search (#12785) ref(ui): Remove some unnecessary index.jsx files (#12606) feat(app-platform): Analytics (#12718) ref(js): Remove ApiMixin (#12384) test(js): Silence project plugin console info spam (#12761) test(js): Move SaveSearchStore.reset() (#12769) test(js): Add more fields to Group fixture (#12759) feat(app-platform): Integration "Learn More" modal (#12638) feat(saved-searches) Move create saved search button to search bar. (#12781) ref(global-header): Remove dead code (#12767) ref(releases): Refactored Releases Serializers (#12535) feat(app-platform): Sort Integrations (#12697) ref(audit-log): Log sso config updates (#12744) ref(app-platform): New 'Open In' UI (#12621) feat(events): Use SnubaEvent if option is turned on (#12594) feat(global-selection-header): show settings icon link in single project mode (#12772) refs(api): Consolidate all search backend code into `SnubaSearchBackend` fix(tests) Remove large snapshots (#12766) fix: Update symbolicator snapshots (#12710) ref: Upgrade semaphore (#12751) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a modal for when the User clicks "Learn More" on the Integrations page, for a Sentry App.
NOTE: The "By undefined" will say "By <author>" once #12622 is merged and out.