Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Nov 5, 2025

This PR cherry-picks 10 commits from main branch related to session replay masking fixes:

Fixes:

Tests:

Maintenance:

Resolved:

  • Merge conflict in SentryUIRedactBuilderTests+Common.swift
  • Updated clang-format version to 21.1.5
  • Cleaned up CHANGELOG to remove unrelated entries

#skip-changelog

@philprime philprime marked this pull request as draft November 5, 2025 15:33
@codecov
Copy link

codecov bot commented Nov 5, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4067 1 4066 25
View the top 1 failed test(s) by shortest run time
iOS_Swift_UITests.LaunchUITests::testLoremIpsum
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift:5 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

- Remove #5591 (minimum OS version warnings) - not related to session replay
- Remove #6019 (SCNetworkReachability) - not related to session replay
- Remove #6377 (thread event issue) - not related to session replay
- Remove #6381 (frame delay) - duplicate/not related to session replay
- Keep only session replay masking related changes
@philprime philprime marked this pull request as ready for review November 5, 2025 15:46
@philprime philprime enabled auto-merge (squash) November 5, 2025 16:21
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am surprised the sdk.json changes were only a couple lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants