-
-
Notifications
You must be signed in to change notification settings - Fork 372
V9 config #5591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V9 config #5591
Conversation
2536254 to
2a059c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5591 +/- ##
=============================================
+ Coverage 86.364% 86.388% +0.023%
=============================================
Files 413 413
Lines 35225 35227 +2
Branches 15347 15337 -10
=============================================
+ Hits 30422 30432 +10
+ Misses 4756 4750 -6
+ Partials 47 45 -2
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f92cfa9 | 1217.94 ms | 1240.06 ms | 22.12 ms |
| 25f2d2c | 1232.02 ms | 1242.78 ms | 10.76 ms |
| 134fbdf | 1219.71 ms | 1240.35 ms | 20.64 ms |
| ea5a59b | 1222.87 ms | 1253.47 ms | 30.60 ms |
| e0424b9 | 1204.23 ms | 1241.08 ms | 36.85 ms |
| fc6557e | 1226.40 ms | 1249.88 ms | 23.48 ms |
| aa0b738 | 1236.78 ms | 1253.08 ms | 16.31 ms |
| 186f06f | 1211.33 ms | 1235.41 ms | 24.08 ms |
| 65f8d2e | 1221.15 ms | 1243.96 ms | 22.81 ms |
| 61414e8 | 1225.49 ms | 1254.28 ms | 28.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f92cfa9 | 23.75 KiB | 855.38 KiB | 831.63 KiB |
| 25f2d2c | 23.75 KiB | 866.69 KiB | 842.94 KiB |
| 134fbdf | 23.75 KiB | 875.25 KiB | 851.50 KiB |
| ea5a59b | 23.75 KiB | 874.46 KiB | 850.71 KiB |
| e0424b9 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| fc6557e | 23.75 KiB | 866.68 KiB | 842.93 KiB |
| aa0b738 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
| 186f06f | 23.75 KiB | 876.94 KiB | 853.19 KiB |
| 65f8d2e | 23.74 KiB | 872.67 KiB | 848.93 KiB |
| 61414e8 | 23.75 KiB | 867.69 KiB | 843.94 KiB |
Previous results on branch: v9Config
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ac22c63 | 1227.98 ms | 1251.04 ms | 23.06 ms |
| bd232b0 | 1236.92 ms | 1261.40 ms | 24.48 ms |
| e526e4f | 1227.48 ms | 1254.94 ms | 27.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ac22c63 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
| bd232b0 | 23.75 KiB | 878.47 KiB | 854.72 KiB |
| e526e4f | 23.75 KiB | 878.48 KiB | 854.73 KiB |
07b8594 to
65d9069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach. I think we should also document this in our https://github.com/getsentry/sentry-cocoa/blob/main/develop-docs/README.md. You could also parts of https://www.notion.so/sentry/sentry-cocoa-V9-2228b10e4b5d80a1bbaadfcaee3b44ca .
Let's give this a shot. Thanks @noahsmartin
This reverts commit 5196f0d.
This reverts commit 5196f0d.
- Remove #5591 (minimum OS version warnings) - not related to session replay - Remove #6019 (SCNetworkReachability) - not related to session replay - Remove #6377 (thread event issue) - not related to session replay - Remove #6381 (frame delay) - duplicate/not related to session replay - Keep only session replay masking related changes
…in (#6678) * fix(session-replay): Update rendering method for fast view rendering (#6360) * fix(session-replay): Extend masking and focus masking on sensitive information (#6292) * test(session-replay): Add masking tests for common cases (#6567) * test(session-replay): Add masking tests for React Native views (#6568) * fix(session-replay): Fix conversion of frame rate to time interval (#6623) * test(session-replay): Add masking tests for edge cases (#6569) * test(session-replay): Add masking tests for UIKit views (#6570) * test(session-replay): Add masking tests for special views (#6571) * fix(session-replay): Include layer background color when checking if a view is opaque (#6629) * chore(tests): Remove snapshot testing to reduce repository size (#6631) * chore: Remove unwanted CHANGELOG entries from cherry-pick - Remove #5591 (minimum OS version warnings) - not related to session replay - Remove #6019 (SCNetworkReachability) - not related to session replay - Remove #6377 (thread event issue) - not related to session replay - Remove #6381 (frame delay) - duplicate/not related to session replay - Keep only session replay masking related changes * docs: Move changelog changes from v8.57.1 to unreleased * test: Resolve wrong assertions involed due to merge-conflict * chore: Update sdk_api_V9.json
Support a new V9 compiler flag that will change the min OS versions + remove deprecated APIs. We can add any V9 specific code behind this flag to ensure it works alongside the current v8 SDK. Also adds a CI check that builds with V9 enabled, providing basic checks that we don't accidentally break the V9 version. This goes with the plan for v9 rollout in notion
#skip-changelog