Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 28, 2025

Derived from #6292 for stacked merging

#skip-changelog

@codecov
Copy link

codecov bot commented Oct 28, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3926 1 3925 15
View the top 1 failed test(s) by shortest run time
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@graphite-app graphite-app bot changed the base branch from philprime/fix-masking_split to graphite-base/6568 October 28, 2025 16:55
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link

graphite-app bot commented Oct 29, 2025

Merge activity

  • Oct 29, 9:56 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Oct 29, 9:56 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@github-actions
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@philprime philprime changed the base branch from graphite-base/6568 to main October 29, 2025 10:43
@philprime philprime enabled auto-merge (squash) October 29, 2025 11:05
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.35 ms 1251.40 ms 34.05 ms
Size 23.75 KiB 1.01 MiB 1016.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
736bcfb 1229.86 ms 1249.59 ms 19.73 ms
37183fe 1212.33 ms 1238.92 ms 26.59 ms
0ac4c65 1221.75 ms 1251.69 ms 29.94 ms
4c719e2 1206.92 ms 1237.45 ms 30.53 ms
fb611a9 1222.63 ms 1254.79 ms 32.16 ms
d8b2303 1231.53 ms 1249.89 ms 18.35 ms
5db87fa 1218.88 ms 1251.53 ms 32.65 ms
005f255 1218.42 ms 1247.09 ms 28.67 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
52588a5 1226.24 ms 1257.22 ms 30.98 ms

App size

Revision Plain With Sentry Diff
736bcfb 23.74 KiB 891.02 KiB 867.28 KiB
37183fe 23.75 KiB 913.63 KiB 889.87 KiB
0ac4c65 23.75 KiB 968.16 KiB 944.41 KiB
4c719e2 23.75 KiB 912.77 KiB 889.02 KiB
fb611a9 23.74 KiB 1022.38 KiB 998.64 KiB
d8b2303 23.75 KiB 908.02 KiB 884.27 KiB
5db87fa 23.75 KiB 926.65 KiB 902.90 KiB
005f255 23.75 KiB 1.01 MiB 1016.13 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
52588a5 23.75 KiB 1.00 MiB 1005.07 KiB

@philprime philprime merged commit 08592dd into main Oct 29, 2025
169 of 173 checks passed
@philprime philprime deleted the philprime/fix-masking_split_2 branch October 29, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants