-
-
Notifications
You must be signed in to change notification settings - Fork 371
test(session-replay): Add masking tests for React Native views #6568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 736bcfb | 1229.86 ms | 1249.59 ms | 19.73 ms |
| 37183fe | 1212.33 ms | 1238.92 ms | 26.59 ms |
| 0ac4c65 | 1221.75 ms | 1251.69 ms | 29.94 ms |
| 4c719e2 | 1206.92 ms | 1237.45 ms | 30.53 ms |
| fb611a9 | 1222.63 ms | 1254.79 ms | 32.16 ms |
| d8b2303 | 1231.53 ms | 1249.89 ms | 18.35 ms |
| 5db87fa | 1218.88 ms | 1251.53 ms | 32.65 ms |
| 005f255 | 1218.42 ms | 1247.09 ms | 28.67 ms |
| d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
| 52588a5 | 1226.24 ms | 1257.22 ms | 30.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 736bcfb | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 37183fe | 23.75 KiB | 913.63 KiB | 889.87 KiB |
| 0ac4c65 | 23.75 KiB | 968.16 KiB | 944.41 KiB |
| 4c719e2 | 23.75 KiB | 912.77 KiB | 889.02 KiB |
| fb611a9 | 23.74 KiB | 1022.38 KiB | 998.64 KiB |
| d8b2303 | 23.75 KiB | 908.02 KiB | 884.27 KiB |
| 5db87fa | 23.75 KiB | 926.65 KiB | 902.90 KiB |
| 005f255 | 23.75 KiB | 1.01 MiB | 1016.13 KiB |
| d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
| 52588a5 | 23.75 KiB | 1.00 MiB | 1005.07 KiB |

Derived from #6292 for stacked merging
#skip-changelog