Remove app extension only flag

[noahsmartin]

Removes the APPLICATION_EXTENSION_API_ONLY flag which is not required anymore. Fixes #5371

The public API json file did change, because it removed SentryRRWebEventType When APPLICATION_EXTENSION_API_ONLY=YES was set, any @objc enum became part of this file, however I confirmed that this type was not in the swiftinterface file, so it isn't actually a breaking public API change.

We did have one test app that was relying on setting the font of SentryUserFeedbackThemeConfiguration in objc, even though this was an internal property and not accessible to Swift. It was only accessible to objc as a side effect of APPLICATION_EXTENSION_API_ONLY=YES so now that we are not leaking internal swift types to objc it cannot be used in the test app.

#skip-changelog

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.220%. Comparing base (65f8d2e) to head (ebc84de).
Report is 1 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #5524       +/-   ##
=============================================
+ Coverage   86.207%   86.220%   +0.012%     
=============================================
  Files          407       407               
  Lines        35034     35030        -4     
  Branches     15018     15003       -15     
=============================================
+ Hits         30202     30203        +1     
+ Misses        4791      4786        -5     
  Partials        41        41               

see 10 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f8d2e...ebc84de. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1238.90 ms	1255.22 ms	16.33 ms
Size	23.75 KiB	872.67 KiB	848.92 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
d38165b	1211.41 ms	1242.49 ms	31.08 ms
db9572a	1200.27 ms	1234.80 ms	34.53 ms
8047b99	1226.37 ms	1246.63 ms	20.26 ms
acac774	1217.76 ms	1253.29 ms	35.52 ms
db9572a	1212.61 ms	1237.73 ms	25.13 ms
2609f7a	1218.17 ms	1241.34 ms	23.17 ms
b13e93a	1236.24 ms	1247.33 ms	11.08 ms
b0e13a7	1227.71 ms	1245.88 ms	18.16 ms
8ea5293	1242.70 ms	1262.25 ms	19.55 ms
35c962f	1207.61 ms	1235.90 ms	28.29 ms

App size

Revision	Plain	With Sentry	Diff
d38165b	23.75 KiB	855.37 KiB	831.62 KiB
db9572a	23.75 KiB	858.69 KiB	834.93 KiB
8047b99	23.75 KiB	855.37 KiB	831.62 KiB
acac774	23.75 KiB	866.51 KiB	842.76 KiB
db9572a	23.75 KiB	858.65 KiB	834.90 KiB
2609f7a	23.75 KiB	867.04 KiB	843.29 KiB
b13e93a	23.75 KiB	855.37 KiB	831.62 KiB
b0e13a7	23.75 KiB	860.98 KiB	837.23 KiB
8ea5293	23.75 KiB	852.24 KiB	828.49 KiB
35c962f	23.75 KiB	854.77 KiB	831.02 KiB

Previous results on branch: removeAppExtensionFlag

Startup times

Revision	Plain	With Sentry	Diff
df45792	1244.47 ms	1255.78 ms	11.31 ms
5679488	1240.80 ms	1263.14 ms	22.35 ms

App size

Revision	Plain	With Sentry	Diff
df45792	23.75 KiB	872.67 KiB	848.93 KiB
5679488	23.75 KiB	872.67 KiB	848.92 KiB

[philipphofmann]

I think this deserves a changelog entry. As the SDK won't throw an error anymore if you set APPLICATION_EXTENSION_API_ONLY_NO in SentryDefines.h

Apart from that LGTM, thank you @noahsmartin

[armcknight]

Thank you for pushing this work forward, can't wait until this is behind us!