fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump #4988

antonis · 2025-07-10T06:13:21Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

⚠️ Based on: #4986

📜 Description

Fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump.

Note that this is a temporary fix to unblock #4986 till getsentry/sentry-cocoa#5606 is release.

💡 Motivation and Context

The following code

  SentryRRWebEvent *nativeBreadcrumb = [self->defaultConverter convertFrom:breadcrumb];

  // ignore native navigation breadcrumbs
  if (nativeBreadcrumb && nativeBreadcrumb.data && nativeBreadcrumb.data[@"payload"]
      && nativeBreadcrumb.data[@"payload"][@"category"] &&
      [nativeBreadcrumb.data[@"payload"][@"category"] isEqualToString:@"navigation"]) {
      return nil;
  }

was failing with (example CI failure)

/packages/core/ios/RNSentryReplayBreadcrumbConverter.m:53:46 Property 'data' not found on object of type 'SentryRRWebEvent *'

/packages/core/ios/RNSentryReplayBreadcrumbConverter.m:53:71 Property 'data' not found on object of type 'SentryRRWebEvent *'

/packages/core/ios/RNSentryReplayBreadcrumbConverter.m:53:75 Array subscript is not an integer

/packages/core/ios/RNSentryReplayBreadcrumbConverter.m:54:29 Property 'data' not found on object of type 'SentryRRWebEvent *'

/packages/core/ios/RNSentryReplayBreadcrumbConverter.m:54:33 Array subscript is not an integer

/packages/core/ios/RNSentryReplayBreadcrumbConverter.m:55:27 Property 'data' not found on object of type 'SentryRRWebEvent *'

/packages/core/ios/RNSentryReplayBreadcrumbConverter.m:55:31 Array subscript is not an integer

due to the changes in getsentry/sentry-cocoa#5524

💚 How did you test it?

Manual, CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

…a 8.53.2 bump

github-actions · 2025-07-10T06:23:51Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	405.62 ms	389.74 ms	-15.88 ms
Size	17.75 MiB	20.15 MiB	2.41 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
`f139dae`	415.36 ms	400.73 ms	-14.63 ms
`ba483fc`	407.51 ms	398.52 ms	-8.99 ms
`6c67a16`	442.07 ms	454.91 ms	12.84 ms

App size

Revision	Plain	With Sentry	Diff
`f139dae`	17.75 MiB	20.15 MiB	2.40 MiB
`ba483fc`	17.75 MiB	20.15 MiB	2.40 MiB
`6c67a16`	17.75 MiB	20.15 MiB	2.40 MiB

Previous results on branch: antonis/cocoa-8.53.2-SentryRRWebEvent

Startup times

Revision	Plain	With Sentry	Diff
`cec705f`	436.46 ms	436.40 ms	-0.06 ms

App size

Revision	Plain	With Sentry	Diff
`cec705f`	17.75 MiB	20.15 MiB	2.41 MiB

github-actions · 2025-07-10T06:35:16Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	336.04 ms	387.16 ms	51.12 ms
Size	7.15 MiB	8.42 MiB	1.27 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
`6c67a16`+dirty	408.86 ms	440.96 ms	32.10 ms
`f139dae`+dirty	383.66 ms	389.28 ms	5.62 ms
`ba483fc`+dirty	432.91 ms	454.14 ms	21.23 ms

App size

Revision	Plain	With Sentry	Diff
`6c67a16`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`f139dae`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`ba483fc`+dirty	7.15 MiB	8.42 MiB	1.26 MiB

Previous results on branch: antonis/cocoa-8.53.2-SentryRRWebEvent

Startup times

Revision	Plain	With Sentry	Diff
`cec705f`+dirty	376.49 ms	409.37 ms	32.88 ms

App size

Revision	Plain	With Sentry	Diff
`cec705f`+dirty	7.15 MiB	8.42 MiB	1.27 MiB

github-actions · 2025-07-10T06:40:19Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.13 ms	1230.56 ms	8.44 ms
Size	2.63 MiB	3.81 MiB	1.18 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
`ba483fc`+dirty	1211.24 ms	1220.49 ms	9.24 ms
`6c67a16`+dirty	1218.27 ms	1224.22 ms	5.96 ms
`f139dae`+dirty	1220.86 ms	1233.21 ms	12.35 ms

App size

Revision	Plain	With Sentry	Diff
`ba483fc`+dirty	2.63 MiB	3.78 MiB	1.15 MiB
`6c67a16`+dirty	2.63 MiB	3.78 MiB	1.15 MiB
`f139dae`+dirty	2.63 MiB	3.80 MiB	1.17 MiB

Previous results on branch: antonis/cocoa-8.53.2-SentryRRWebEvent

Startup times

Revision	Plain	With Sentry	Diff
`cec705f`+dirty	1221.12 ms	1223.96 ms	2.84 ms

App size

Revision	Plain	With Sentry	Diff
`cec705f`+dirty	2.63 MiB	3.81 MiB	1.18 MiB

github-actions · 2025-07-10T06:42:50Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1220.53 ms	1216.27 ms	-4.27 ms
Size	3.19 MiB	4.38 MiB	1.19 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
`ba483fc`+dirty	1203.07 ms	1213.62 ms	10.55 ms
`6c67a16`+dirty	1220.52 ms	1223.47 ms	2.95 ms
`f139dae`+dirty	1213.82 ms	1215.87 ms	2.05 ms

App size

Revision	Plain	With Sentry	Diff
`ba483fc`+dirty	3.19 MiB	4.35 MiB	1.17 MiB
`6c67a16`+dirty	3.19 MiB	4.35 MiB	1.16 MiB
`f139dae`+dirty	3.19 MiB	4.36 MiB	1.17 MiB

Previous results on branch: antonis/cocoa-8.53.2-SentryRRWebEvent

Startup times

Revision	Plain	With Sentry	Diff
`cec705f`+dirty	1218.45 ms	1218.51 ms	0.06 ms

App size

Revision	Plain	With Sentry	Diff
`cec705f`+dirty	3.19 MiB	4.38 MiB	1.19 MiB

…-SentryRRWebEvent

lucas-zimerman · 2025-07-11T08:51:31Z

are you planning to undo this fix after a new cocoa release is done?

antonis · 2025-07-11T08:54:08Z

are you planning to undo this fix after a new cocoa release is done?

Yes the changes on this PR can be reverted as soon as getsentry/sentry-cocoa#5606 gets released

lucas-zimerman

LGTM!
Lets just make a simple issue to remind that we need to rollback this code once a new release of cocoa is made

antonis · 2025-07-11T09:05:52Z

Lets just make a simple issue to remind that we need to rollback this code once a new release of cocoa is made

Opened #4991

* chore: update scripts/update-cocoa.sh to 8.53.2 * fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump (#4988) * chore: update scripts/update-cocoa.sh to 8.53.2 * fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump * Remove duplicate changelog entry after merge --------- Co-authored-by: GitHub <noreply@github.com> --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>

web-flow and others added 2 commits July 10, 2025 03:27

chore: update scripts/update-cocoa.sh to 8.53.2

a995573

fix(session-replay): fixes navigation breadcrumb filtering after Coco…

3e7af65

…a 8.53.2 bump

antonis mentioned this pull request Jul 10, 2025

chore(deps): update Cocoa SDK to v8.53.2 #4986

Merged

bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 3 times, most recently from 26b416d to a81285b Compare July 10, 2025 10:11

antonis added 2 commits July 10, 2025 17:02

Merge branch 'deps/scripts/update-cocoa.sh' into antonis/cocoa-8.53.2…

995ea24

…-SentryRRWebEvent

Remove duplicate changelog entry after merge

ee74808

noahsmartin mentioned this pull request Jul 10, 2025

Update visibility for RN SDK getsentry/sentry-cocoa#5606

Merged

antonis marked this pull request as ready for review July 10, 2025 15:30

antonis requested a review from lucas-zimerman as a code owner July 10, 2025 15:30

lucas-zimerman approved these changes Jul 11, 2025

View reviewed changes

antonis merged commit e71b4c2 into deps/scripts/update-cocoa.sh Jul 11, 2025
162 of 169 checks passed

antonis deleted the antonis/cocoa-8.53.2-SentryRRWebEvent branch July 11, 2025 09:06

Uh oh!

fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump #4988

fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump #4988

Uh oh!

Conversation

antonis commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

App size

Previous results on branch: antonis/cocoa-8.53.2-SentryRRWebEvent

Startup times

App size

Uh oh!

github-actions bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

App size

Previous results on branch: antonis/cocoa-8.53.2-SentryRRWebEvent

Startup times

App size

Uh oh!

github-actions bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

App size

Previous results on branch: antonis/cocoa-8.53.2-SentryRRWebEvent

Startup times

App size

Uh oh!

github-actions bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

App size

Previous results on branch: antonis/cocoa-8.53.2-SentryRRWebEvent

Startup times

App size

Uh oh!

lucas-zimerman commented Jul 11, 2025

Uh oh!

antonis commented Jul 11, 2025

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

antonis commented Jul 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

antonis commented Jul 10, 2025 •

edited

Loading

github-actions bot commented Jul 10, 2025 •

edited

Loading

github-actions bot commented Jul 10, 2025 •

edited

Loading

github-actions bot commented Jul 10, 2025 •

edited

Loading

github-actions bot commented Jul 10, 2025 •

edited

Loading