Remove app extension only flag

CHANGELOG.md

@@ -6,6 +6,10 @@
 
 - Set handled to false for fatal app hangs (#5514)
 
+### Improvements
+
+- Removed `APPLICATION_EXTENSION_API_ONLY` requirement (#5524)
+
 ## 8.53.1
 
 ### Fixes

Package.swift

@@ -54,8 +54,7 @@ if let env, String(cString: env, encoding: .utf8) == "1" {
             dependencies: ["_SentryPrivate", "SentryHeaders"],
             path: "Sources/Swift",
             swiftSettings: [
-                // The application extension flag is required due to https://github.com/getsentry/sentry-cocoa/issues/5371
-                .unsafeFlags(["-enable-library-evolution", "-Xfrontend", "-application-extension"]),
+                .unsafeFlags(["-enable-library-evolution"]),
                 // This flag is used to make some API breaking changes necessary for the framework to compile with SPM.
                 // We can either make more extensive changes to allow it to be backwards compatible, or release them as part of a V9 release.
                 // For now we use this flag so that CI can compile the SPM version.

Samples/iOS-ObjectiveC/iOS-ObjectiveC/AppDelegate.m

@@ -122,7 +122,6 @@ - (BOOL)application:(UIApplication *)application
                     uiForm.useSentryUser = YES;
                 };
                 config.configureTheme = ^(SentryUserFeedbackThemeConfiguration *_Nonnull theme) {
-                    theme.font = [UIFont fontWithName:@"ChalkboardSE-Regular" size:25];
                     theme.outlineStyle =
                         [[SentryFormElementOutlineStyle alloc] initWithColor:UIColor.purpleColor
                                                                 cornerRadius:10

Sentry.podspec

@@ -21,11 +21,8 @@ Pod::Spec.new do |s|
       'GCC_ENABLE_CPP_EXCEPTIONS' => 'YES',
       'CLANG_CXX_LANGUAGE_STANDARD' => 'c++14',
       'CLANG_CXX_LIBRARY' => 'libc++',
-      # APPLICATION_EXTENSION_API_ONLY has a side effect of exposing all `@objc` marked entities in `Sentry-Swift.h` (regardless of access level)
-      # This is currently needed for Sentry module to compile. Changing this to NO will break the build.
-      'APPLICATION_EXTENSION_API_ONLY' => 'YES',
       'SWIFT_INCLUDE_PATHS' => '${PODS_TARGET_SRCROOT}/Sources/Sentry/include',
-      'OTHER_CFLAGS' => '$(inherited) -DAPPLICATION_EXTENSION_API_ONLY_$(APPLICATION_EXTENSION_API_ONLY)'
+      'OTHER_CFLAGS' => '$(inherited)'
   }
   s.watchos.pod_target_xcconfig = {
       'OTHER_LDFLAGS' => '$(inherited) -framework WatchKit'

Sources/Configuration/Sentry.xcconfig

@@ -23,10 +23,7 @@ MODULEMAP_FILE = $(SRCROOT)/Sources/Resources/$(PRODUCT_MODULE_NAME_$(CONFIGURAT
 ARCHS = $(ARCHS_STANDARD) arm64e
 ARCHS[sdk=*simulator] = $(ARCHS_STANDARD)
 
-// APPLICATION_EXTENSION_API_ONLY YES causes a side effect of exposing all @objc classes to Sentry-Swift.h
-// and without it the project wont compile.
-APPLICATION_EXTENSION_API_ONLY = YES
-OTHER_CFLAGS = -DCARTHAGE_$(CARTHAGE) -DAPPLICATION_EXTENSION_API_ONLY_$(APPLICATION_EXTENSION_API_ONLY)
+OTHER_CFLAGS = -DCARTHAGE_$(CARTHAGE)
 
 BUILD_LIBRARY_FOR_DISTRIBUTION = YES
 INSTALL_PATH = $(LOCAL_LIBRARY_DIR)/Frameworks

Sources/Sentry/Public/SentryDefines.h

@@ -1,26 +1,5 @@
 #import <Foundation/Foundation.h>
 
-// SentryDefines.h is a key header and will be checked early,
-// ensuring this error appears first during the compile process.
-//
-// Setting APPLICATION_EXTENSION_API_ONLY to YES has a side effect of
-// including all Swift classes in the `Sentry-Swift.h` header which is
-// required for the SDK to work.
-//
-// https://github.com/getsentry/sentry-cocoa/issues/4426
-//
-// This mainly came up in RN SDK, because
-// some libraries advice to users
-// to set APPLICATION_EXTENSION_API_ONLY_NO
-// for all cocoapods targets, instead of
-// only to their pod.
-// https://github.com/getsentry/sentry-react-native/issues/3908
-#if APPLICATION_EXTENSION_API_ONLY_NO
-#    error "Set APPLICATION_EXTENSION_API_ONLY to YES in the Sentry build settings.\
- Setting the flag to YES is required for the SDK to work.\
- For more information, visit https://docs.sentry.io/platforms/apple/troubleshooting/#unknown-receiver-somereceiver-use-of-undeclared-identifier-someidentifier
-#endif
-
 // Clang warns if a double quoted include is used instead of angle brackets in a public header
 // These 3 import variations are how public headers can be imported with angle brackets
 // for Sentry, SentryWithoutUIKit, and SPM

Tests/Configuration/SentryTests.xcconfig

@@ -12,4 +12,3 @@ ALWAYS_SEARCH_USER_PATHS = NO
 CLANG_ENABLE_OBJC_ARC = YES
 CLANG_ENABLE_MODULES = YES
 OTHER_CFLAGS = -Wall -Wextra
-APPLICATION_EXTENSION_API_ONLY = NO