feat(js): Export live option type for releases.uploadSourceMaps
#2627
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
RulaKhaled and
andreiborza
and removed request for
a team
js/releases/index.js
Outdated
| * ext: ['js', 'map', 'jsbundle', 'bundle'], // override file extensions to scan for | ||
| * projects: ['node'], // provide a list of projects | ||
| * decompress: false // decompress gzip files before uploading | ||
| * live: undefined // whether to inherit stdio to display `sentry-cli` output directly. |
There was a problem hiding this comment.
Why is live undefined? Seems wrong but maybe this is just some JS thing I don't understand 🫣
There was a problem hiding this comment.
Good catch, thanks! Forgot that the default value is actually true 🤦♂️
szokeasaurusrex
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2605, I missed that we also need to add the new
liveoption to the manually created public type declaration of theSentryCLI().releases.uploadSourceMapsmethod. This PR now adds theliveoption to this method. (feat because although there's no behaviour change, from a user perspective #2605 is only public with this change)Very good reason to tackle #2617, since it will eliminate this kind of divergence. I gave it a quick try and got results pretty quickly. However, due to our internal typing currently being a lot more lenient than what the type declarations specify, I'd consider unifying the typing a breaking change. The goal is that our exported type declarations come from out internal type definitions BUT to get to this point, we first need to change these internal types to adhere to the currently exported declarations.
@szokeasaurusrex let me know when you want to tackle v3, then I'll take another look at this.