feat(js): Expose rejectOnError in public execute type declarations
#2628
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
approved these changes
Jul 18, 2025
|
@Lms24 is this actually a Oh wait, there is some |
|
yes, it's as much a feat as #2627 was one. thx for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course I missed more occurances of the
livemode in type declarations 🤦♂️(no urgency this time though)
This PR now adds the new
rejectOnErrorto the remaining.executetype declarations so that this mode can also be set by library consumers directly calling.execute(e.g.@sentry/react-routerSDK).