-
-
Notifications
You must be signed in to change notification settings - Fork 235
feat(js): Add live: 'rejectOnError'
execution mode to execute
method
#2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live: rejectOnError
execution mode to execute
methodlive: 'rejectOnError'
execution mode to execute
method
szokeasaurusrex
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, see comments prior to merge
Also perhaps would be good for someone more well-versed in JS to also take a glance at this before we merge |
2b989fc
to
cc6f642
Compare
chargome
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sentry CLI JS interface's
execute
method takes alive
parameter as a second argument:false
, stdio is returned and the promise returned fromexecute
rejects/resolves based on the CLI binary's exit code.true
, CLI stdio is piped to the process callingexecute
, but the returned promise always resolves regardless of the exit code (raised in Exit code ignored withSentryCli.execute([...], true)
(live mode) #2062)This PR adds a third value (
'rejectOnError'
) tolive
, which still pipes stdio but also rejects if the CLI binary's exit code was non-zero. Arguably, this is whattrue
should do but to avoid a breaking change for now, let's introduce this as a new value instead.This PR also makes a second small change, which is to allow the
Releases.uploadSourceMaps
method to forward alive
option to its.execute
call. This is necessary because at the moment,uploadSourceMaps
always calls.execute
withlive: true
but in case of the bundler plugins, we want to use the newlive: 'rejectOnError'
mode.Also added a couple of unit tests
closes #2062
ref getsentry/sentry-javascript-bundler-plugins#670