wip: Introduce new metric to measure root transactions [INGEST-1575] #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GEST-1575] We basically want to measure how often the transaction name changes during the lifecycle of a transaction.
jjbayer
approved these changes
Aug 22, 2022
| let event = some_or!(event, return); | ||
| let sampling_project_state = some_or!(sampling_project_state, return); | ||
|
|
||
| if sampling_project_state.project_id != project_state.project_id { |
There was a problem hiding this comment.
Suggested change
| if sampling_project_state.project_id != project_state.project_id { | |
| // We only collect this metric for the root transaction event, so ignore secondary projects. | |
| if sampling_project_state.project_id != project_state.project_id { |
jan-auer
changed the title
Instructions and example for changelogFor changes exposed to the Python package, please add an entry to For changes to the Relay server, please add an entry to
To the changelog entry, please add a link to this PR (consider a more descriptive message): - Introduce new metric to measure root transactions. ([#1432](https://github.com/getsentry/relay/pull/1432))If none of the above apply, you can opt out by adding #skip-changelog to the PR description. |
|
Replaced by #1466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This PR contains temporary metrics to measure how often the transaction name changes
during the lifecycle of a transaction.