Skip to content

test: Use similar_asserts and introduce test modules #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 23, 2022

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Aug 23, 2022

Updates tests with a more modern assertion framework and improved structuring:

  • Use similar-asserts instead of custom macros for comparison
  • Introduce test modules for all unit tests
  • Hoist all imports in test functions into the test module
  • Use fully qualified insta assertions instead of imports
  • Inline a single-use macro to compare bytes

#skip-changelog

@jan-auer jan-auer requested a review from a team August 23, 2022 11:19
@jan-auer jan-auer force-pushed the build/similar-asserts branch from d30c102 to 45fbe9a Compare August 23, 2022 11:19
@jan-auer jan-auer enabled auto-merge (squash) August 23, 2022 11:24
@jan-auer jan-auer merged commit 4531dd8 into master Aug 23, 2022
@jan-auer jan-auer deleted the build/similar-asserts branch August 23, 2022 11:39
jan-auer added a commit that referenced this pull request Aug 23, 2022
* master:
  test: Use similar_asserts and introduce test modules (#1435)
  build: Update insta to 1.19.0 (#1434)
  ref: Move envelope queueing directly into the endpoint handler (#1431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants