feat(protocol): Track transaction name changes #1466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2022
AbhiPrasad
approved these changes
Sep 13, 2022
jjbayer
reviewed
Sep 13, 2022
jjbayer
approved these changes
Sep 14, 2022
jan-auer
added a commit
that referenced
this pull request
Sep 22, 2022
Follow-up to #1466 that fixes some outlier conditions: - Assume a 0% change vs propagations ratio when there were no changes - Log timing metrics even if there was no change (using the start timestamp) - Skip changes at the end of every transaction (i.e. event processors)
jan-auer
added a commit
that referenced
this pull request
Dec 5, 2022
The metrics introduced in #1466 are no longer needed and can be removed. We keep the protocol to ingest information about propagations, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
propagationsandchangesthat provides more insight into how atransaction name was changed during the lifetime of a transaction span. Since
the transaction name is propagated to downstream SDKs as part of the Dynamic
Sampling Context (DSC), this is a relevant quality metric for sampling traces by
transaction name.
All traces where propagations occur before the final transaction name is set
may not be sampled consistently if there are rules matching on the transaction
name.
Ref getsentry/sentry-javascript#5679