Skip to content

Conversation

@matthew-white
Copy link
Member

@matthew-white matthew-white commented May 24, 2023

This PR makes progress on getodk/central#410 by updating AnalyticsPreview with the metric added in getodk/central-backend#889. For the text, I used the label in the form attached to the Backend PR.

What has been done to verify that this works as intended?

num_updated_entities is structured very similarly to num_failed_entities: both are groups in the nested repeat group /projects/datasets. I based this change on what was done previously for num_failed_entities.

I also took a look at the new metric locally. The dataset metrics are in their own table, so the text has the full width of the modal — so there shouldn't be space/overflow concerns. Screenshot:

Screen Shot 2023-05-24 at 12 44 52 AM

Why is this the best possible solution? Were any other approaches considered?

Following existing patterns.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The risk of regression should be low.

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

No changes needed.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white requested a review from sadiqkhoja May 24, 2023 04:54
Copy link
Contributor

@sadiqkhoja sadiqkhoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the metric name to num_entity_updates in getodk/central-backend#889

@matthew-white matthew-white merged commit da77ddf into master May 26, 2023
@matthew-white matthew-white deleted the update-analytics branch May 26, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants