Improve scalability when using gxhttpclient #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for reusing the connection pool of httpclient instances. Avoided using CookieContainer of handlers, as they are shared across the pooled connections. Instead, managed sending and receiving cookies as headers.
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
ggallotti
reviewed
Mar 13, 2024
…stency with other keys, such as HTTPCLIENT_MAX_PER_ROUTE
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Ignore cookies in container that are invalid for the current url.
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
… no HasFormContentType. Use async operations when possible for httpclient connectionProperties was not caching empty values
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit 4f77cb3
|
Collaborator
Manual cherry pick to beta success |
Enable Microsoft.VisualStudio.Threading.Analyzers
Collaborator
Collaborator
Manual revert to beta success |
ggallotti
previously approved these changes
Apr 1, 2024
…the ServicePointManager.ServerCertificateValidationCallback may change after the first handler has been created. Therefore, subsequent calls cannot reuse the same handler.
Collaborator
Cherry pick to beta failed, 3 conflicted files in commit 4f77cb3
|
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Manual cherry pick to beta success |
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit cd6c42e
|
Collaborator
Manual cherry pick to beta success |
Collaborator
Cherry pick to beta failed, 1 conflicted file in commit c855419
|
Collaborator
Manual cherry pick to beta success |
Collaborator
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored gxhttpclient to utilize a singleton instance, configurable, for improved scalability and efficient connection pooling. Eliminated the use of CookieContainer in handlers to prevent shared state issues across pooled connections. Implemented cookie management through headers.
Issue:106775