Skip to content

Improve scalability when using gxhttpclient #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 11, 2024
Merged

Improve scalability when using gxhttpclient #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6167032
Refactored gxhttpclient implementation to utilize a singleton instanc…
claudiamurialdo Mar 1, 2024
de2d2db
Change public method by internal.
claudiamurialdo Mar 1, 2024
7053cc9
Merge branch 'master' into httpclient-singleton
claudiamurialdo Mar 12, 2024
3279793
Honor property Maximum pool size per route.
claudiamurialdo Mar 12, 2024
54af1d3
Define const for DEFAULT_HTTPCLIENT_MAX_PER_ROUTE.
claudiamurialdo Mar 12, 2024
1372598
Rename SINGLETON_HTTPCLIENT to HTTPCLIENT_SINGLETON to maintain consi…
claudiamurialdo Mar 13, 2024
4e20cb3
Add trace for HttpClient.
claudiamurialdo Mar 15, 2024
4f77cb3
Avoid InvalidOperationException in HttpRequest.GetValue when there is…
claudiamurialdo Mar 19, 2024
cd6c42e
Prepare for async calls to httpclient.
claudiamurialdo Mar 20, 2024
c855419
Fix build error.
claudiamurialdo Mar 21, 2024
f55d323
Revert changes related to async and keep only the httpclient singleto…
claudiamurialdo Mar 26, 2024
5213a67
Consider SslOptions when creating the key for SocketsHttpHandler, as …
claudiamurialdo Apr 4, 2024
7e2ea84
Add ToStringAsync and ExecuteAsync methods to HttpClient.
claudiamurialdo Apr 4, 2024
a674d46
ExecuteAsync must be public as it is used from generated code.
claudiamurialdo Apr 5, 2024
01705e1
Remove unnecessary call to ReceiveData (sync method) in ToStringAsync
claudiamurialdo Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions dotnet/src/dotnetframework/GxClasses/Core/gxconfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,7 @@ public class Preferences
const string DEFAULT_DS = "Default";
static int httpclient_max_per_route = -1;
static int sessionTimeout = -1;
static int singletonHttpClient = -1;
internal static string AppMainNamespace
{
get
Expand Down Expand Up @@ -1443,6 +1444,18 @@ internal static bool WrapSingleApiOutput
return DefaultWrapSingleApiOutput;
}
}

internal static bool SingletonHttpClient()
{
if (singletonHttpClient == -1)
{
if (Config.GetValueOrEnvironmentVarOf("HTTPCLIENT_SINGLETON", out string sValue) && int.TryParse(sValue, out int value))
singletonHttpClient = value;
else
singletonHttpClient = 1;
}
return singletonHttpClient==1;
}
internal static string CorsAllowedOrigins()
{
if (Config.GetValueOf("CORS_ALLOW_ORIGIN", out string corsOrigin))
Expand Down Expand Up @@ -1484,27 +1497,27 @@ public static string GetDefaultTheme()
else
return "";
}

public static int GetHttpClientMaxConnectionPerRoute()
internal const int DEFAULT_HTTPCLIENT_MAX_PER_ROUTE= 1000;
internal static int GetHttpClientMaxConnectionPerRoute()
{
if (httpclient_max_per_route == -1)
{
try
{
string strmax;
if (Config.GetValueOf("HTTPCLIENT_MAX_PER_ROUTE", out strmax))
if (Config.GetValueOrEnvironmentVarOf("HTTPCLIENT_MAX_PER_ROUTE", out strmax))
{
httpclient_max_per_route = Convert.ToInt32(strmax);
}
else
{
httpclient_max_per_route = 1000;
httpclient_max_per_route = DEFAULT_HTTPCLIENT_MAX_PER_ROUTE;
}
}
catch (Exception ex)
{
GXLogging.Error(log, "HttpClientMaxPerRoute error", ex);
httpclient_max_per_route = 1000;
httpclient_max_per_route = DEFAULT_HTTPCLIENT_MAX_PER_ROUTE;
}
}
return httpclient_max_per_route;
Expand Down
Loading