Add trace for HttpClient.

Ignore cookies in container that are invalid for the current url.

Author: claudiamurialdo

dotnet/src/dotnetframework/GxClasses/Domain/GxHttpClient.cs

@@ -161,6 +161,7 @@ private static HttpClient GetHttpClientInstance(Uri URI, int timeout, ArrayList
 				string key = HttpClientInstanceIdentifier(proxyHost, proxyPort, fileCertificateCollection, timeout);
 				if (_httpClientInstances.TryGetValue(key, out value))
 				{
+					GXLogging.Debug(log, $"Getting httpClient cached instance");
 					return value;
 				}
 				else
@@ -169,6 +170,7 @@ private static HttpClient GetHttpClientInstance(Uri URI, int timeout, ArrayList
 					{
 						if (_httpClientInstances.TryGetValue(key, out value))
 						{
+							GXLogging.Debug(log, $"Getting httpClient cached instance");
 							return value;
 						}
 						value = new HttpClient(GetHandler(URI, authCollection, authProxyCollection, certificateCollection, proxyHost, proxyPort));
@@ -212,10 +214,11 @@ private static SocketsHttpHandler GetHandler(Uri URI, ArrayList authCollection,
 				PooledConnectionLifetime = TimeSpan.FromMinutes(POOLED_CONNECTION_LIFETIME_MINUTES),
 			};
 			int maxConnections = Preferences.GetHttpClientMaxConnectionPerRoute();
-			if (maxConnections != 0)
+			if (maxConnections != Preferences.DEFAULT_HTTPCLIENT_MAX_PER_ROUTE)
 			{
 				handler.MaxConnectionsPerServer = maxConnections;
 			}
+			GXLogging.Debug(log, $"Creating SocketsHttpHandler MaxConnectionsPerServer:{handler.MaxConnectionsPerServer}");
 			handler.Credentials = getCredentialCache(URI, authCollection);
 
 			if (ServicePointManager.ServerCertificateValidationCallback != null)

dotnet/src/dotnetframework/GxClasses/Helpers/HttpHelper.cs

@@ -76,6 +76,8 @@ public class WrappedJsonError
 #if NETCORE
 	internal static class CookiesHelper
 	{
+		static readonly IGXLogger log = GXLoggerFactory.GetLogger(typeof(CookiesHelper).FullName);
+
 		internal static void PopulateCookies(this HttpRequestMessage request, CookieContainer cookieContainer)
 		{
 			if (cookieContainer != null)
@@ -94,12 +96,19 @@ private static string ToHeaderFormat(this IEnumerable<Cookie> cookies)
 		}
 		internal static void ExtractCookies(this HttpResponseMessage response, CookieContainer cookieContainer)
 		{
-			if (response.Headers.TryGetValues("Set-Cookie", out var cookieEntries))
+			if (response.Headers.TryGetValues("Set-Cookie", out var cookieValues))
 			{
 				Uri uri = response.RequestMessage.RequestUri;
-				foreach (string cookieEntry in cookieEntries)
+				foreach (string cookieValue in cookieValues)
 				{
-					cookieContainer.SetCookies(uri, cookieEntry);
+					try
+					{
+						cookieContainer.SetCookies(uri, cookieValue);
+					}
+					catch (CookieException ex)
+					{
+						GXLogging.Warn(log, $"Ignored cookie for container: {cookieValue} url:{uri}", ex);
+					}
 				}
 
 			}