Add authors to all workflows #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvdbeek do you have a script to do a minor release with an automatic message to put in CHANGELOG.md? |
lldelisle
commented
Nov 20, 2023
| ## [0.1.7] 2023-11-20 | ||
|
|
||
| - Fix author in dockstore | ||
|
|
There was a problem hiding this comment.
There is no changelog for 0.1.6 @mvdbeek @Delphine-L
I did what I tell my biologist not to do... I did it manually like a monkey... Anyhow, it is done. |
|
Maybe I need to split this PR into pieces because the deployment will probably be skipped because lint will fail as well as other tests, no? |
|
There is https://github.com/galaxyproject/iwc/blob/main/bump_version.py for bumping versions. This slipped past review though, we don't support the unreleased section in planemo and it would appear in the changelogs if not removed. |
Right ... maybe we should skip tests on merge ? |
|
Here is the report of tests: Test Results (powered by Planemo)Test Summary
Errored Tests
|
|
The error in the gromacs workflow is real, for the rest it's SRA data that isn't available anymore. |
|
Indeed I was making the list:
|
|
For pe-wgs-ivar-analysis, the version 3.1.14+galaxy0 with changeset_revision fe3e8506112c has disappeared from the toolshed (probably number 10) as another file with the same version has been uploaded but this version is not a valid tool: https://toolshed.g2.bx.psu.edu/repository?repository_id=aaec941c4dfce850&changeset_revision=073de3fb84a0 |
|
yep, if you go to https://toolshed.g2.bx.psu.edu/repository?repository_id=aaec941c4dfce850&changeset_revision=fe3e8506112c you can see this is a broken revision |
|
(though I think you should still be able to trigger an installation for a changeset revision that is not installable, in which case you should get the next installable revision) |
|
But it is installed on org: |
|
Should I put all sars-cov2 fastqs on zenodo? |
|
I was working on a script to do that, but maybe we should just do that manually until they've actually clarified which API should be used for that. |
|
(I put the whole fastq from the SRA, right?) |
|
yes |
|
I am closer: Test Results (powered by Planemo)Test Summary
Errored Tests
Failed Tests
|
|
For Should I allow more line diff or update the expected result? |
|
Looks like DP has increased slightly, I would assume that's a fix coming from a newer version ?? Let's update the test result ? (ping @wm75). |
lldelisle
force-pushed
the
add_authors_to_all
branch
from
eaa52c5
to
1df11b7
Compare
lldelisle
force-pushed
the
add_authors_to_all
branch
from
1df11b7
to
ef87050
Compare
|
Here we are: Test Results (powered by Planemo)Test Summary
|
|
@mvdbeek ready for review. This PR is only:
The workflows which required more changes are adressed into separated PR: #293 and #295 |
|
😍 Awesome, you really rock! |
mvdbeek
approved these changes
Nov 23, 2023
|
This is my Swiss influence. I like when thinks are straight and clear. |
|
(Because of the failing lint step we may need to force deployement no?) |
|
No, linting should be excluded from the deployment requirements: https://github.com/galaxyproject/iwc/blob/main/.github/workflows/workflow_test.yml#L122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
for f in $(find $(pwd) -name ".dockstore.yml"); do echo $f; cd $(dirname $f); planemo dockstore_init .; doneand then manually check if it was a real change or just a reordering of workflows and manually update version and CHANGELOG.md.