-
Notifications
You must be signed in to change notification settings - Fork 24
feat: updated Schemas and Intents #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Goal The goal of this PR is to implement *only* the *types* and *pallet storage* for the following new on-chain entities: * Intents * IntentGroups Closes #2561 **NOTE:** No tests or benchmarks added in this PR, as it only contains types and storage, no executable runtime code (coming in a separate PR) # Checklist - [x] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [x] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented? # Conflicts: # runtime/frequency/src/lib.rs
…ntGroup) (#2563) # Description This PR implments type, storage, and runtime RPCs for mapping fully qualified names of the form `<protocol>.<descriptor>` to Intents or IntentGroups. Additional tests & support will be the subject of an upcoming PR; this is only merging to a feature branch. Closes #2562 # Discussion - <!-- List discussion items --> # Checklist - [ ] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented?
b91436b to
6307cc1
Compare
# Goal The goal of this PR is to implement the extrinsics, RPCs and unit tests for Intents and IntentGroups. Closes #2564 # Discussion - <!-- List discussion items --> # Checklist - [x] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [x] Unit Tests added? - [ ] e2e Tests added? - [x] Benchmarks added? - [ ] Spec version incremented?
# Goal The goal of this PR is to update the types, extrinsics, and runtime APIs for the Schemas pallet to conform to the new design Closes #2580 # Checklist - [ ] Updated Pallet Readme? - [x] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [x] Benchmarks added? - [ ] Spec version incremented? --------- Co-authored-by: Shannon Wells <shannonwells@users.noreply.github.com> Co-authored-by: Aramik <aramikm@gmail.com>
# Goal The goal of this PR is to migrate the `messages` pallet to add `schema_id` to message storage, and use `intent_id` as the index instead. Existing index values do not need to be changed, as the `schemas` pallet migration ensures that the chain is seeded with Intent IDs that match existing Schema IDs Related to #2581 # Checklist - [ ] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [x] Unit Tests added? - [ ] e2e Tests added? - [x] Benchmarks added? - [ ] Spec version incremented?
# Goal The goal of this PR is to implement the changes necessary to update the `stateful-storage` and `msa` pallets to use the new Schemas and Intents framework. This includes a migration of child trie storage in the `stateful-storage` pallet. Closes #2581
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking from me!
aramikm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Tremendous effort and great feature to add.
enddynayn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great efforts!
Goal
The goal of this PR is to implement the design described here
Tracking epic: #2550
Checklist