Implement types and pallet storage for Intents and IntentGroups #2560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
metadata-changed
JoeCap08055
requested review from
a team,
aramikm,
claireclark1,
enddynayn,
mattheworris,
saraswatpuneet and
shannonwells
and removed request for
a team
aramikm
approved these changes
Aug 14, 2025
Collaborator
aramikm
left a comment
aramikm
left a comment
There was a problem hiding this comment.
Looks good and some tests will need to get fixed.
|
|
||
| /// Maximum number of Intents that can be registered | ||
| #[pallet::constant] | ||
| type MaxIntentRegistrations: Get<IntentId>; |
Collaborator
There was a problem hiding this comment.
nit: This is not used anywhere.
Collaborator
Author
There was a problem hiding this comment.
It will be once the extrinsics are implemented.
Collaborator
Author
There was a problem hiding this comment.
Q for the group: I implemented MaxIntentRegistrations because there was already a corresponding MaxSchemaRegistrations. However, given that both ID types are u16, and the constant is currently set to 65_000 (close enough to max u16), I wonder if it would make sense to allow 65_536 registrations and just check for an add overflow when adding a new schema? Would eliminate the need for both constants. Not a runtime or storage efficiency change, but just less design complexity...
...or, if we want to keep the constant, should we just use the same constant for both?
Thoughts?
JoeCap08055
commented
Aug 15, 2025
Collaborator
Author
There was a problem hiding this comment.
Some updates to the design doc based on a Slack conversation with @wesbiggs. Mainly renaming DelegationGroup => IntentGroup
github-actions
bot
added
metadata-changed
github-actions
bot
removed
metadata-changed
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
github-actions
bot
added
metadata-changed
JoeCap08055
merged commit 88d6d93
into
feat/schemas-permissions-development
88 of 92 checks passed
JoeCap08055
added a commit
that referenced
this pull request
Aug 20, 2025
# Goal The goal of this PR is to implement *only* the *types* and *pallet storage* for the following new on-chain entities: * Intents * IntentGroups Closes #2561 **NOTE:** No tests or benchmarks added in this PR, as it only contains types and storage, no executable runtime code (coming in a separate PR) # Checklist - [x] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [x] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented? # Conflicts: # runtime/frequency/src/lib.rs
JoeCap08055
added a commit
that referenced
this pull request
Aug 22, 2025
# Goal The goal of this PR is to implement *only* the *types* and *pallet storage* for the following new on-chain entities: * Intents * IntentGroups Closes #2561 **NOTE:** No tests or benchmarks added in this PR, as it only contains types and storage, no executable runtime code (coming in a separate PR) # Checklist - [x] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [x] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented? # Conflicts: # pallets/schemas/src/lib.rs # pallets/schemas/src/tests/other_tests.rs # pallets/schemas/src/types.rs # runtime/frequency/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to implement only the types and pallet storage for the following new on-chain entities:
Closes #2561
NOTE: No tests or benchmarks added in this PR, as it only contains types and storage, no executable runtime code (coming in a separate PR)
Checklist