Skip to content

Conversation

@JoeCap08055
Copy link
Collaborator

Description

This PR implments type, storage, and runtime RPCs for mapping fully qualified names of the form <protocol>.<descriptor> to Intents or IntentGroups.

Additional tests & support will be the subject of an upcoming PR; this is only merging to a feature branch.

Closes #2562

Discussion

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@JoeCap08055 JoeCap08055 requested a review from wilwade as a code owner August 18, 2025 15:37
@JoeCap08055 JoeCap08055 requested review from a team, aramikm, claireclark1, enddynayn, mattheworris, saraswatpuneet and shannonwells and removed request for a team August 18, 2025 15:37
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
common/primitives/src/schema.rs 0.00% 9 Missing ⚠️
pallets/schemas/src/types.rs 0.00% 3 Missing ⚠️
pallets/schemas/src/lib.rs 92.30% 2 Missing ⚠️
Files with missing lines Coverage Δ
pallets/schemas/src/lib.rs 83.57% <92.30%> (ø)
pallets/schemas/src/types.rs 90.00% <0.00%> (ø)
common/primitives/src/schema.rs 43.75% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 18, 2025
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm some nits

Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code. I have no blocking questions/concerns of my own, looks good assuming Aramik's question is answered!

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 19, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 20, 2025
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 20, 2025
@JoeCap08055 JoeCap08055 merged commit b91436b into feat/schemas-permissions-development Aug 20, 2025
31 of 32 checks passed
@JoeCap08055 JoeCap08055 deleted the feat/intent-name-registry branch August 20, 2025 15:25
JoeCap08055 added a commit that referenced this pull request Aug 20, 2025
…ntGroup) (#2563)

# Description
This PR implments type, storage, and runtime RPCs for mapping fully
qualified names of the form `<protocol>.<descriptor>` to Intents or
IntentGroups.

Additional tests & support will be the subject of an upcoming PR; this
is only merging to a feature branch.

Closes #2562 

# Discussion

- <!-- List discussion items -->

# Checklist
- [ ] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [ ] Unit Tests added?
- [ ] e2e Tests added?
- [ ] Benchmarks added?
- [ ] Spec version incremented?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants