-
Notifications
You must be signed in to change notification settings - Fork 24
feat: types, storage, and runtime RPCs for entity Names (Intent, IntentGroup) #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: types, storage, and runtime RPCs for entity Names (Intent, IntentGroup) #2563
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
saraswatpuneet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm some nits
shannonwells
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code. I have no blocking questions/concerns of my own, looks good assuming Aramik's question is answered!
b91436b
into
feat/schemas-permissions-development
…ntGroup) (#2563) # Description This PR implments type, storage, and runtime RPCs for mapping fully qualified names of the form `<protocol>.<descriptor>` to Intents or IntentGroups. Additional tests & support will be the subject of an upcoming PR; this is only merging to a feature branch. Closes #2562 # Discussion - <!-- List discussion items --> # Checklist - [ ] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented?
Description
This PR implments type, storage, and runtime RPCs for mapping fully qualified names of the form
<protocol>.<descriptor>to Intents or IntentGroups.Additional tests & support will be the subject of an upcoming PR; this is only merging to a feature branch.
Closes #2562
Discussion
Checklist