Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid empty list and None values in attribute_filters #2202

Merged
merged 15 commits into from
Jan 22, 2025
Prev Previous commit
Next Next commit
catch error in migration script
  • Loading branch information
ychiucco committed Jan 22, 2025
commit 888eb0eb7810e43dd9ad20298e462301d5d68098
27 changes: 15 additions & 12 deletions fractal_server/data_migrations/2_11_0.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,18 +92,21 @@ def fix_db():
stm = select(JobV2).order_by(JobV2.id)
jobs = db.execute(stm).scalars().all()
for job in jobs:
job.dataset_dump["type_filters"] = job.dataset_dump["filters"][
"types"
]
job.dataset_dump["attribute_filters"] = dict_values_to_list(
job.dataset_dump["filters"]["attributes"],
f"JobV2[{job.id}].dataset_dump.filters.attributes",
)
job.dataset_dump.pop("filters")
flag_modified(job, "dataset_dump")
JobReadV2(**job.model_dump())
db.add(job)
logger.info(f"Fixed filters in JobV2[{job.id}].datasetdump")
try:
job.dataset_dump["type_filters"] = job.dataset_dump["filters"][
"types"
]
job.dataset_dump["attribute_filters"] = dict_values_to_list(
job.dataset_dump["filters"]["attributes"],
f"JobV2[{job.id}].dataset_dump.filters.attributes",
)
job.dataset_dump.pop("filters")
flag_modified(job, "dataset_dump")
JobReadV2(**job.model_dump())
db.add(job)
logger.info(f"Fixed filters in JobV2[{job.id}].datasetdump")
except RuntimeError as e:
logger.info(f"Skipping JobV2[{job.id}]. Error: '{e}'.")

db.commit()
logger.info("Changes committed.")
Expand Down
Loading