Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid empty list and None values in attribute_filters #2202

Merged
merged 15 commits into from
Jan 22, 2025
Merged

Forbid empty list and None values in attribute_filters #2202

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1c72aca
forbid attribute_filters=[]
ychiucco Jan 21, 2025
494c75f
Merge branch 'dev-2.11' into 2200-forbid-attribute_filterskey1
ychiucco Jan 21, 2025
6df8436
remove None from attribute type
ychiucco Jan 21, 2025
c599307
update invalid attribute filters test
ychiucco Jan 21, 2025
c911bf8
fix data migration bug with attribute filters
ychiucco Jan 22, 2025
5bd4e31
add validation in data migration
ychiucco Jan 22, 2025
251f6a2
fix read schemas
ychiucco Jan 22, 2025
30671bb
remove None case from validator
ychiucco Jan 22, 2025
d6ef642
remove None case from match_filter
ychiucco Jan 22, 2025
888eb0e
catch error in migration script
ychiucco Jan 22, 2025
e30edac
fix tests
ychiucco Jan 22, 2025
7260e8b
Merge branch 'dev-2.11' into 2200-forbid-attribute_filterskey1
ychiucco Jan 22, 2025
e4b6718
changelog
ychiucco Jan 22, 2025
55c7668
changelog
ychiucco Jan 22, 2025
4a3e8c9
Minor changes to data-migration script
tcompa Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changelog
  • Loading branch information
@ychiucco
ychiucco committed Jan 22, 2025
commit 55c76680831c5176e39a2ae5851f666042b4ac84
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@

* API:
* Impose compatibility between `WorkflowTaskV2.type_filters` and `TaskV2.input_types` (\#2196).
* Schemas:
* Forbid `None` or `[]` as `attribute_filters` (\#2200).

# 2.11.0a4
Loading