Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid empty list and None values in attribute_filters #2202

Draft
wants to merge 4 commits into
base: dev-2.11
Choose a base branch
from

Conversation

ychiucco
Copy link
Collaborator

closes #2200
closes #2186

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

Copy link

github-actions bot commented Jan 21, 2025

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.8 0.8 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.3 9.4 1.10 0.6 0.6
power 366.3 396.7 0.92 345.4 366.2
dataset 133.3 150.8 0.88 123.2 134.0
project 38.3 47.8 0.80 43.9 47.2
job 22.6 27.6 0.82 29.7 32.4

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.6 6.9 0.96 2.2 2.2
power 129.5 137.6 0.94 662.6 652.2
dataset 133.9 142.9 0.94 916.0 905.2
project 46.7 46.1 1.01 287.2 283.8
job 36.6 41.0 0.89 227.6 224.9

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.3 7.5 0.97 0.1 0.1
power 7.1 7.1 1.00 0.1 0.1
dataset 7.1 7.6 0.93 0.1 0.1
project 9.0 9.9 0.91 2.3 2.3
job 7.6 7.5 1.01 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.9 6.1 0.97 0.8 0.8
power 6.0 6.5 0.92 0.8 0.8
dataset 6.3 6.4 0.98 0.8 0.8
project 6.6 6.6 1.00 0.8 0.8
job 6.0 6.4 0.94 0.8 0.8

GET /api/v2/task-group/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.0 8.2 0.85 1.6 1.6
power 7.2 7.8 0.92 1.6 1.6
dataset 6.9 7.5 0.92 1.6 1.6
project 6.8 7.5 0.91 1.6 1.6
job 6.9 7.4 0.93 1.6 1.6

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.0 12.5 0.88 0.8 0.8
power 24.4 27.0 0.90 28.0 29.1
dataset 21.0 20.6 1.02 16.2 16.7
project 21.4 23.2 0.92 20.4 21.0
job 11.8 11.3 1.04 0.8 0.8

POST /api/v2/project/3/dataset/405/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 142.4 141.6 1.01 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.0 5.1 0.98 0.2 0.2
power 4.9 4.7 1.04 0.2 0.2
dataset 4.9 4.5 1.09 0.2 0.2
project 5.2 4.8 1.08 0.2 0.2
job 4.9 4.8 1.02 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 273.9 274.1 1.00 0.2 0.2

Copy link

github-actions bot commented Jan 21, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/schemas
  _filter_validators.py
  fractal_server/images
  models.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant