Events API#279
Merged
Merged
Conversation
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
kumare3
commented
Dec 11, 2025
| prompt="Is it ok to continue?", | ||
| data_type=bool, | ||
| ) | ||
| event2 = await flyte.new_event.aio( |
Contributor
Author
There was a problem hiding this comment.
We should allow users to make the prompt fancy, like html etc (reports)
And then we should also have an even type that is a webhook invocation with a callback to signal
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Enqueue rejected condition actions because input_uri was empty and the proto enforces min_len=1. Pass a placeholder inputs path from register_event through from_condition. Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
ActionUpdate carries the condition payload on field `value`; wire it through Action.condition_output and convert via literal_to_python in wait_for_event so event.wait() returns the bool/int/float/str instead of always None. Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
Mirror the task/trace path so the inputs_uri stamped on a condition action resolves to a real (empty LiteralMap) blob and the backend's GetActionData read no longer 404s. Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
Resolve _controller.py conflict by keeping submit_and_wait_for_action rename from conditions over submit_action from main. Drop dead trace/timing call to _trace_enabled_for in _core._bg_wait_for_action left over after the debug-log cleanup in #1127. Signed-off-by: Sergey Vilgelm <sergey@union.ai>
This reverts commit 00f5103. Signed-off-by: Sergey Vilgelm <sergey@union.ai>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
SVilgelm
previously approved these changes
May 29, 2026
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org>
New `flyte signal event <run> <action> <value>` resolves a paused condition action. The value is coerced to bool/int/float/str using the condition's declared LiteralType, read from ActionMetadata.condition.type. Falls back gracefully when the field isn't yet populated by the backend. Also adds Event.expected_type for SDK callers and drops the stale signal_event_remotely helper in the events example. Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
Signed-off-by: Sergey Vilgelm <sergey@union.ai>
`flyte signal event <run> <action>` now reads the condition's prompt (and prompt_type) from the backend and pops an interactive click.prompt typed to the expected payload. Passing `<value>` keeps the previous non-interactive shape but also prints the prompt and the value being signaled before sending. Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
Lists events for a run, optionally filtered to a parent action via the existing remote.Event.listall (which already filters list_actions to ACTION_TYPE_CONDITION). Adds Event.__rich_repr__ so table output shows event name, action id, run, phase, parent, and the inferred payload type when the backend exposes it. Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@union.ai>
Resolve _controller.RemoteController.__init__ conflict by keeping both new attributes: _submit_init_lock from #1130 (lock around submit_sync) and _pending_events from conditions (event registration store). Signed-off-by: Sergey Vilgelm <sergey@union.ai>
SVilgelm
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.