Update edit settings to remove unused string list setting #1117
Merged
Conversation
kumare3
reviewed
May 27, 2026
| except Exception as e: | ||
| console.print(f"[red]Error fetching settings:[/red] {e}") | ||
| raise click.Abort | ||
| settings = remote.Settings.get_settings_for_edit(project=project, domain=domain) |
Contributor
Author
There was a problem hiding this comment.
When dogfood was misconfigured i actually got an exception while trying to test, and this re-throwing of an error hides the exception. The exception gets displayed with less noise if there isnt a re-throw.
what it says is that during the handling of the exception, another error was thrown - so you get two stacks, and it isnt clear that they have anything to do with each other.
Contributor
|
you will have to signoff on dco and also make fmt |
afbrock
force-pushed
the
main
branch
4 times, most recently
from
cf12959 to
a56ee1a
Compare
… maps The label setting changed types from string list to map, and was the only instance of a string list. This change removes the unused type. It also improves how maps display entries from different scopes. Each entry is displayed on its own line with a comment as to its source scope. Signed-off-by: Adam Brock <adam@union.ai>
kumare3
approved these changes
May 29, 2026
SVilgelm
pushed a commit
that referenced
this pull request
May 29, 2026
kumare3
pushed a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also improves string map handling.
The label setting changed types from string list to map, and was the only instance of a string list. This change removes the unused type. It also improves how maps display entries from different scopes. Each entry is displayed on its own line with a comment as to its source scope.