[webview_flutter_android] Adds support for receiving Java callback `WebChromeClient.onShowFileChooser` #6881

bparrishMines · 2022-12-24T17:30:35Z

Adds WebChromeClient.onShowFileChooser callback method.
Adds FileChooserParams class since its passed to onShowFileChooser.
Adds AndroidWebViewController.setOnShowFileSelector.
Moves WebChromeClient from AndroidNavigationDelegate to AndroidWebViewController since the callback is set by the controller.

Note: This callback is only supported for versions 21+.

Fixes flutter/flutter#27924 and flutter/flutter#97127

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan-g · 2023-01-03T15:42:07Z

So, I added a helper method (FileChooserParams.openFilePickerForResult()) that handles starting an Activity and retrieving the result.

I was thinking that openFilePickerForResult could be used as the default functionality for Android. Therefore, a user wouldn't need the file_picker plugin to handle this.

I thought the decision from the previous discussion of option was that we would start with not providing a default, and suggest that people use file_selector as the implementation, so that we didn't have to maintain two copies of essentially the same code that we already have in file_selector (flutter/flutter#27924 (comment)). Why the change in approach? Could we scope this PR down to just providing the callback part without a default implementation or helper, release that, and see if we actually need more that just an example of implementing it with file_selector (or maybe directly with file_selector_android to cut down on overhead to other platforms)?

stuartmorgan-g · 2023-01-03T15:42:44Z

I assume this PR will obsolete #5172?

dupuchba · 2023-01-12T08:10:50Z

Thank you both for your work 🙇

stuartmorgan-g

A couple of questions, but overall LGTM!

Once file_selector_android lands we should consider updating the example app for this package to show using it to handle this callback.

stuartmorgan-g · 2023-01-13T18:56:32Z

...roid/android/src/main/java/io/flutter/plugins/webviewflutter/WebChromeClientHostApiImpl.java

+          fileChooserParams,
+          reply -> {
+            // The returned list of file paths can only be passed to `filePathCallback` if the
+            // `onShowFileChooser` method returned true.


Shouldn't we just not call flutterApi.onShowFileChooser in the first place if this is true? Or is the idea that you could in theory want to know when it's called (on the Dart side) without actually handling it?

Yea, I assumed there could be a situation where someone could want to know when a user clicks on the <input name="userfile" type="file"> button. I don't think it hurts to keep it this way.

stuartmorgan-g · 2023-01-13T18:59:07Z

packages/webview_flutter/webview_flutter_android/lib/src/android_webview.dart

+  ) {
+    assert(
+      !value || onShowFileChooser != null,
+      'Setting this to true requires `onShowFileChooser` to be nonnull.',


assert is debug-only; this should probably be a StateError.

rashidotm · 2023-01-17T18:05:10Z

Thanks for the effort. I am looking forward to upgrade as soon as it is released. 🔥🔥

Approximately, what is the timeline on it?

stuartmorgan-g · 2023-01-17T18:57:53Z

As with all PRs, it will land when it's fully reviewed and approved.

…ebChromeClient.onShowFileChooser` (flutter#6881) * some progress * more work * compiling code * dart side should be correct * maybe working code * fix plugin class * formatting * some docs and polish * foramtting tests and docs * version bump * doc improvements * flutterapi create test * working java test * unused imports * formatting and more tests * formatting and more tests * formatting * copy and tests * add more description to the custom method * formatting * change doc wording * more docs * null out result early * remove the open option * fix spelling * interface implementation * version bump * move webchromeclient to webview controller * tests * reference method in changelong * missing typed data import * undo changes * use stateerror instead * updated lints

kennetgo · 2023-02-01T11:21:36Z

Can somebody please provide an example code to use setOnShowFileSelector, for an AndroidWebViewController. Thanks

stuartmorgan-g · 2023-02-01T11:56:01Z

@kennetgo flutter/flutter#118836 is tracking that, as mentioned in the original issue.

bparrishMines added 11 commits December 19, 2022 15:01

some progress

a81107b

more work

fff4697

Merge branch 'main' of github.com:flutter/plugins into onShowFileChooser

735015f

compiling code

5ba566a

dart side should be correct

829982b

maybe working code

cd37e4a

fix plugin class

2f28144

formatting

3bdfaf2

some docs and polish

98ebdca

foramtting tests and docs

9f7e891

version bump

2ef08bd

github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android labels Dec 24, 2022

bparrishMines added 11 commits December 24, 2022 12:48

doc improvements

a11d012

flutterapi create test

7311007

working java test

07b866c

unused imports

3665866

formatting and more tests

56467e6

formatting and more tests

a15a2dc

formatting

94c4032

copy and tests

d4f818a

add more description to the custom method

0bdf90a

formatting

b57f39f

change doc wording

6e7c334

bparrishMines changed the title ~~On show file chooser~~ [webview_flutter_android] Adds support for receiving Java callback WebChromeClient.onShowFileChooser Dec 25, 2022

bparrishMines added 2 commits December 24, 2022 21:28

more docs

8685a9e

null out result early

ac60b45

bparrishMines requested a review from stuartmorgan-g December 27, 2022 14:47

bparrishMines added 7 commits January 4, 2023 11:37

interface implementation

9e17836

version bump

e66649c

move webchromeclient to webview controller

cf4e79d

tests

d015bb5

reference method in changelong

3184656

missing typed data import

6374117

undo changes

c522e4a

bparrishMines mentioned this pull request Jan 11, 2023

[webview_flutter] Add file upload on Android #5172

Closed

14 tasks

This was referenced Jan 11, 2023

[webview_flutter] Add listener for scroll position change in Android #2107

Closed

[webview_flutter] add mixedContentMode option for Android WebView #2468

Closed

[webview_flutter] - Added WebViewSetting option for iOS #4339

Closed

stuartmorgan-g approved these changes Jan 13, 2023

View reviewed changes

bparrishMines added 3 commits January 19, 2023 16:03

use stateerror instead

e5a063c

version bump

bcf94e0

updated lints

7b83113

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 19, 2023

auto-submit bot merged commit 5f44021 into flutter:main Jan 19, 2023

stuartmorgan-g mentioned this pull request Jan 19, 2023

[webview_flutter] Add example file chooser callback to README flutter/flutter#118836

Open

bparrishMines mentioned this pull request Jan 19, 2023

[webview_flutter_android] Fix throwing StateError when onShowFileChooser was nonnull #6995

Merged

11 tasks

bparrishMines deleted the onShowFileChooser branch January 20, 2023 04:09

bparrishMines mentioned this pull request Jan 20, 2023

[webview_flutter] camera not opening for (input type="file" capture="user" accept="image/*") flutter/flutter#97127

Closed

bparrishMines mentioned this pull request Jan 26, 2023

[webview_flutter] navigationDelegate, onPageStarted, onPageFinished not always called flutter/flutter#108801

Closed

This comment was marked as duplicate.

Sign in to view

darshankawar mentioned this pull request Jul 17, 2023

On my Android (Galaxy S10) not opening the camera or gallery flutter/flutter#129428

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[webview_flutter_android] Adds support for receiving Java callback `WebChromeClient.onShowFileChooser` #6881

[webview_flutter_android] Adds support for receiving Java callback `WebChromeClient.onShowFileChooser` #6881

Uh oh!

bparrishMines commented Dec 24, 2022 •

edited

Loading

Uh oh!

stuartmorgan-g commented Jan 3, 2023

Uh oh!

stuartmorgan-g commented Jan 3, 2023

Uh oh!

dupuchba commented Jan 12, 2023

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Jan 13, 2023

Uh oh!

bparrishMines Jan 19, 2023

Uh oh!

stuartmorgan-g Jan 13, 2023

Uh oh!

rashidotm commented Jan 17, 2023

Uh oh!

stuartmorgan-g commented Jan 17, 2023

Uh oh!

kennetgo commented Feb 1, 2023

Uh oh!

stuartmorgan-g commented Feb 1, 2023

Uh oh!

This comment was marked as duplicate.

Uh oh!

[webview_flutter_android] Adds support for receiving Java callback WebChromeClient.onShowFileChooser #6881

[webview_flutter_android] Adds support for receiving Java callback WebChromeClient.onShowFileChooser #6881

Uh oh!

Conversation

bparrishMines commented Dec 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

stuartmorgan-g commented Jan 3, 2023

Uh oh!

stuartmorgan-g commented Jan 3, 2023

Uh oh!

dupuchba commented Jan 12, 2023

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jan 13, 2023

Choose a reason for hiding this comment

Uh oh!

bparrishMines Jan 19, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Jan 13, 2023

Choose a reason for hiding this comment

Uh oh!

rashidotm commented Jan 17, 2023

Uh oh!

stuartmorgan-g commented Jan 17, 2023

Uh oh!

kennetgo commented Feb 1, 2023

Uh oh!

stuartmorgan-g commented Feb 1, 2023

Uh oh!

This comment was marked as duplicate.

Uh oh!

[webview_flutter_android] Adds support for receiving Java callback `WebChromeClient.onShowFileChooser` #6881

[webview_flutter_android] Adds support for receiving Java callback `WebChromeClient.onShowFileChooser` #6881

bparrishMines commented Dec 24, 2022 •

edited

Loading