Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_android] Fix throwing StateError when onShowFileChooser was nonnull #6995

Merged
merged 2 commits into from
Jan 20, 2023
Merged

[webview_flutter_android] Fix throwing StateError when onShowFileChooser was nonnull #6995

merged 2 commits into from
Jan 20, 2023

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jan 19, 2023 •
edited
Loading

Fix to #6881

The release of 3.2.0 has not finished yet, so I wanted to try and sneak this fix in and release webview_flutter_android manually.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android labels Jan 19, 2023
@bparrishMines bparrishMines changed the title fix chooser [webview_flutter_android] Fix throwing StateError when onShowFileChooser was nonnull Jan 19, 2023
stuartmorgan-g
stuartmorgan-g approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines
Copy link
Contributor Author

Merging on red to fix a bug before a release.

@bparrishMines bparrishMines merged commit ffb36e0 into flutter:main Jan 20, 2023
@bparrishMines bparrishMines deleted the fix_chooser branch January 20, 2023 03:09
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@bparrishMines @mauricioluz
[webview_flutter_android] Fix throwing StateError when `onShowFileC…
8e4de3c 
…hooser` was nonnull (flutter#6995)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
p: webview_flutter Edits files for a webview_flutter plugin platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bparrishMines @stuartmorgan-g