Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] add mixedContentMode option for Android WebView #2468

Closed
wants to merge 1 commit into from

Conversation

dotcink
Copy link

@dotcink dotcink commented Jan 14, 2020

Description

Add support of mixedContentMode for Android WebView.

Related Issues

Fixes flutter/flutter#43595 and flutter/flutter#24975

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@dotcink dotcink requested a review from amirh as a code owner January 14, 2020 18:16
@dotcink
Copy link
Author

dotcink commented Feb 6, 2020

@amirh Please Take A Look.
Thank you.

@dotcink
Copy link
Author

dotcink commented Feb 13, 2020

Not sure what's the meaning of branch-guard — Cirrus CI failure.
This failing check didn't show at first.
Clicking Details shows error message:

{
  "message": "If you would like to help us test the Checks API during its preview period, you must specify a custom media type in the 'Accept' header. Please see the docs for full details.",
  "documentation_url": "https://developer.github.com/v3/checks/suites/#get-a-single-check-suite"
}

@edisonywh
Copy link

Thanks for the great work @dotcink! Any update on this, @amirh? Right now my app just looks pretty jarring with unloaded images everywhere.

@dotcink
Copy link
Author

dotcink commented Mar 15, 2020

Thanks for the great work @dotcink! Any update on this, @amirh? Right now my app just looks pretty jarring with unloaded images everywhere.

Please thumbs up 👍 flutter/flutter#43595, Flutter team use this to guide the issue prioritizing.

Copy link

@ikkyu0319 ikkyu0319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ~

@stuartmorgan-g stuartmorgan-g added the p: webview_flutter Edits files for a webview_flutter plugin label Jan 29, 2021
@Vasques1995
Copy link

Hi @dotcink any news on the issue this PR is trying to address? The only reason that the PR is not merged is because of the failed checks?

@dotcink
Copy link
Author

dotcink commented Mar 16, 2021

Hi @dotcink any news on the issue this PR is trying to address? The only reason that the PR is not merged is because of the failed checks?

I just submitted another common solution. This PR might close if possible.

@dotcink dotcink force-pushed the mixedContentMode branch 3 times, most recently from 0c07379 to f456a47 Compare March 17, 2021 05:20
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue.

@ditman
Copy link
Member

ditman commented Jun 3, 2021

I just submitted another common solution. This PR might close if possible.

Closing in favor of: #3721

@dotcink
Copy link
Author

dotcink commented Jun 4, 2021

I just submitted another common solution. This PR might close if possible.

Closing in favor of: #3721

So would #3721 be prepared to be reviewed and merged please?

@stuartmorgan-g
Copy link
Contributor

I just submitted another common solution. This PR might close if possible.

Closing in favor of: #3721

There isn't a decision yet that that's the way we want to go, so for now both should stay open.

@stuartmorgan-g stuartmorgan-g reopened this Jun 4, 2021
@stuartmorgan-g
Copy link
Contributor

So would #3721 be prepared to be reviewed and merged please?

Please see #3721 (comment)

@stuartmorgan-g
Copy link
Contributor

Adding a setting for this makes sense in the new structure we'll be using, but it's blocked on flutter/flutter#94051: we'll want to support platform extensions to WebSettings instead of adding this to the main class, and have a way of configuring the web view that doesn't require yet another highly-specific optional parameter.

We can leave this open for now and it can be adjusted to fit the new structure once that work is done.

(/cc @bparrishMines and @mvanbeusekom who will be working on that restructing.)

@godofredoc godofredoc changed the base branch from master to main January 6, 2022 22:14
@stuartmorgan-g stuartmorgan-g removed the request for review from amirh February 8, 2022 16:11
@stuartmorgan-g
Copy link
Contributor

Status update from triage: Still blocked on flutter/flutter#94051, which is being worked on.

@Hixie
Copy link
Contributor

Hixie commented May 10, 2022

Latest status is that we're still waiting on flutter/flutter#94051.
Before this can land even after that is fixed, the conflicts will need to be resolved.

@dotcink
Copy link
Author

dotcink commented May 12, 2022

Latest status is that we're still waiting on flutter/flutter#94051. Before this can land even after that is fixed, the conflicts will need to be resolved.

OK, I'll resolve the conflicts according to the new solution.

@stuartmorgan-g
Copy link
Contributor

Status update from triage: still blocked, but we hope to be unblocked soon.

@stuartmorgan-g
Copy link
Contributor

webview_flutter v4 has finally been completed, which included fixing the platform interface to that we can make additions to it without breaking changes. That means that this is finally unblocked! Thanks for your patience while we worked through the restructuring.

webview_flutter v4 uses a Dart-first implementation, where the platform channel boundary is as close as possible to the underlying host APIs, and plugin logic is written primarily in Dart rather than the host language. That means that this PR will need to be updated to follow that model. Please let us know if you have questions about updating to v4 (and #6881 may be useful as an example of adding a feature in the v4 structure).

@stuartmorgan-g
Copy link
Contributor

@dotcink Are you still planning on updating this for compatibility with v4?

@stuartmorgan-g
Copy link
Contributor

(Marking this as a Draft pending that update.)

@stuartmorgan-g stuartmorgan-g marked this pull request as draft February 14, 2023 21:00
@dotcink
Copy link
Author

dotcink commented Feb 22, 2023

OK, I'll check the new v4 in the weekend.

@stuartmorgan-g
Copy link
Contributor

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.

Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.

Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: webview_flutter Edits files for a webview_flutter plugin platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[webview_flutter] Add option to allow mixed-mode content (http in https page)
8 participants