-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[webview_flutter] add mixedContentMode
option for Android WebView
#2468
Conversation
@amirh Please Take A Look. |
Not sure what's the meaning of
|
Please thumbs up 👍 flutter/flutter#43595, Flutter team use this to guide the issue prioritizing. |
4b94446
to
e172b0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice ~
Hi @dotcink any news on the issue this PR is trying to address? The only reason that the PR is not merged is because of the failed checks? |
I just submitted another common solution. This PR might close if possible. |
e172b0c
to
b0e0a58
Compare
0c07379
to
f456a47
Compare
f456a47
to
760d0a5
Compare
Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue. |
Closing in favor of: #3721 |
There isn't a decision yet that that's the way we want to go, so for now both should stay open. |
Please see #3721 (comment) |
Adding a setting for this makes sense in the new structure we'll be using, but it's blocked on flutter/flutter#94051: we'll want to support platform extensions to We can leave this open for now and it can be adjusted to fit the new structure once that work is done. (/cc @bparrishMines and @mvanbeusekom who will be working on that restructing.) |
Status update from triage: Still blocked on flutter/flutter#94051, which is being worked on. |
Latest status is that we're still waiting on flutter/flutter#94051. |
OK, I'll resolve the conflicts according to the new solution. |
Status update from triage: still blocked, but we hope to be unblocked soon. |
webview_flutter v4 has finally been completed, which included fixing the platform interface to that we can make additions to it without breaking changes. That means that this is finally unblocked! Thanks for your patience while we worked through the restructuring. webview_flutter v4 uses a Dart-first implementation, where the platform channel boundary is as close as possible to the underlying host APIs, and plugin logic is written primarily in Dart rather than the host language. That means that this PR will need to be updated to follow that model. Please let us know if you have questions about updating to v4 (and #6881 may be useful as an example of adding a feature in the v4 structure). |
@dotcink Are you still planning on updating this for compatibility with v4? |
(Marking this as a Draft pending that update.) |
OK, I'll check the new v4 in the weekend. |
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
Description
Add support of
mixedContentMode
for Android WebView.Related Issues
Fixes flutter/flutter#43595 and flutter/flutter#24975
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?