[webview_flutter] Adds support to control whether to draw scrollbars #9024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
added
the
federated: all_changes
bparrishMines
changed the title
11 tasks
| /// Whether the horizontal scrollbar should be drawn or not. | ||
| Future<void> setHorizontalScrollBarEnabled(bool enabled) { | ||
| return platform.setHorizontalScrollBarEnabled(enabled); | ||
| } |
There was a problem hiding this comment.
Can you also plumb through a Future<bool> supportsSetScrollBarsEnabled() method to the platform interface layer that clients can use to detect whether this is safe to call per https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#api-support-queries ? This won't make sense on all platforms, so we should expect that clients will need a support query indefinitely.
There was a problem hiding this comment.
I'm also assuming you meant for this to return bool and not Future<bool> too?
There was a problem hiding this comment.
Oops, I missed this, and didn't catch it in the platform interface review. It should have been Future<bool> in case there were a platform that could only determine this at runtime (e.g., based on the OS version).
Not a big deal though as that's an unlikely case to ever hit.
auto-submit bot
pushed a commit
that referenced
this pull request
May 13, 2025
…raw the scrollbar (#9125) Part of flutter/flutter#62464 Platform interface portion for #9024 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
May 14, 2025
…set whether to draw the scrollbar (#9249) Platform implementations of #9024 Part of flutter/flutter#62464 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
stuartmorgan-g
approved these changes
May 15, 2025
| /// should be drawn or not. | ||
| /// | ||
| /// See [setVerticalScrollBarEnabled] and [setHorizontalScrollBarEnabled]. | ||
| bool supportsSetScrollBarsEnabled() { |
There was a problem hiding this comment.
Let's still make this Future<bool> at this layer so that in the unlikely event that we have to change things we can keep the user-facing API the same, and only add a duplicate method at the platform interface layer.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 19, 2025
flutter/packages@58d4016...af0b9a9 2025-05-19 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support to respond to recoverable SSL certificate errors (flutter/packages#9281) 2025-05-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20250107 to 20250517 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#9283) 2025-05-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20250107 to 20250517 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#9282) 2025-05-16 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds support to respond to recoverable SSL certificate errors (flutter/packages#9248) 2025-05-16 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to control whether to draw scrollbars (flutter/packages#9024) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…raw the scrollbar (flutter#9125) Part of flutter/flutter#62464 Platform interface portion for flutter#9024 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…set whether to draw the scrollbar (flutter#9249) Platform implementations of flutter#9024 Part of flutter/flutter#62464 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…lutter#9024) Fixes flutter/flutter#62464 Updated version of flutter#8174 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#62464
Updated version of #8174
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3