Skip to content

[webview_flutter_android][webview_flutter_wkwebview] Adds support to set whether to draw the scrollbar #9249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented May 13, 2025

Platform implementations of #9024
Part of flutter/flutter#62464

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@bparrishMines bparrishMines changed the title Scrollbar impls [webview_flutter_android][webview_flutter_wkwebview] Adds support to set whether to draw the scrollbar May 13, 2025
@bparrishMines bparrishMines added the federated: partial_changes PR that contains changes for only a single package of a federated plugin change label May 13, 2025
@bparrishMines bparrishMines marked this pull request as ready for review May 14, 2025 15:36
@bparrishMines bparrishMines requested review from stuartmorgan-g and removed request for cbracken and LouiseHsu May 14, 2025 15:36
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2025
@auto-submit auto-submit bot merged commit c2a5648 into flutter:main May 14, 2025
82 checks passed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2025
Copy link
Contributor

auto-submit bot commented May 14, 2025

auto label is removed for flutter/packages/9249, Failed to merge flutter/packages/9249 with ClientException: Connection closed while receiving data, uri=https://api.github.com/repos/flutter/packages/pulls/9249/merge.

@bparrishMines bparrishMines deleted the scrollbar_impls branch May 14, 2025 15:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request May 15, 2025
flutter/packages@1468581...2dff621

2025-05-15 10687576+bparrishMines@users.noreply.github.com [pigeon]
Prevents premature finalization from unused Dart instance for ProxyApis
(flutter/packages#9231)
2025-05-14 louisehsu@google.com [in_app_purchase] Bump
`in_app_purchase_storekit` version (flutter/packages#9247)
2025-05-14 engine-flutter-autoroll@skia.org Roll Flutter from
336a7ec to 0b9f928 (22 revisions) (flutter/packages#9251)
2025-05-14 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android][webview_flutter_wkwebview] Adds support to set
whether to draw the scrollbar (flutter/packages#9249)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…set whether to draw the scrollbar (flutter#9249)

Platform implementations of flutter#9024
Part of flutter/flutter#62464

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
federated: partial_changes PR that contains changes for only a single package of a federated plugin change p: webview_flutter platform-android platform-ios platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants