-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[webview_flutter_platform_interface] Adds support to respond to recoverable SSL certificate errors #9248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webview_flutter_platform_interface] Adds support to respond to recoverable SSL certificate errors #9248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/// the error and continue communicating with the server. | ||
/// | ||
/// **Warning:** When an SSL error occurs, the host application should always | ||
/// call [cancel] rather than [proceed] because an invalid SSL certificate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was supposed to get the same wording change as above: "Warning: This should generally only be called in test environments, as using it in production can expose users to security and privacy risks."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to match: #9150 (comment)
…d to recoverable SSL certificate errors (flutter/packages#9248)
…d to recoverable SSL certificate errors (flutter/packages#9248)
flutter/packages@58d4016...af0b9a9 2025-05-19 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support to respond to recoverable SSL certificate errors (flutter/packages#9281) 2025-05-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20250107 to 20250517 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#9283) 2025-05-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20250107 to 20250517 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#9282) 2025-05-16 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds support to respond to recoverable SSL certificate errors (flutter/packages#9248) 2025-05-16 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to control whether to draw scrollbars (flutter/packages#9024) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…erable SSL certificate errors (flutter#9248) Platform interface portion of flutter#9150 Part of flutter/flutter#36925 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Platform interface portion of #9150
Part of flutter/flutter#36925
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3