Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[various] Sync lints with flutter/flutter #5717

Merged
merged 16 commits into from
Jan 3, 2024
Merged

[various] Sync lints with flutter/flutter #5717

merged 16 commits into from
Jan 3, 2024

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 18, 2023

Applying the latest analysis_options.yaml from flutter/flutter to this repo. Most fixes were auto-generated by dart fix.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
Copy link
Contributor

auto-submit bot commented Jan 3, 2024

auto label is removed for flutter/packages/5717, due to - The status or check suite Windows_x64 win32-platform_tests_shard_2 stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
Copy link
Contributor

auto-submit bot commented Jan 3, 2024

auto label is removed for flutter/packages/5717, due to - The status or check suite Linux_android android_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
Copy link
Contributor

auto-submit bot commented Jan 3, 2024

auto label is removed for flutter/packages/5717, due to - The status or check suite Linux_android android_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@goderbauer goderbauer merged commit bb97da8 into flutter:main Jan 3, 2024
80 checks passed
@goderbauer goderbauer deleted the lintSync23 branch January 3, 2024 23:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 4, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 4, 2024
flutter/packages@bbb4134...31fc7b5

2024-01-04 christopherfujino@gmail.com bump mockito across repo to 5.4.4 (flutter/packages#5794)
2024-01-03 goderbauer@google.com [various] Sync lints with flutter/flutter (flutter/packages#5717)
2024-01-03 ditman@gmail.com [pointer_interceptor_web] Update package APIs and tests. (flutter/packages#5785)
2024-01-03 stuartmorgan@google.com [google_sign_in] Correct method channel `clearAuthCache` declaration (flutter/packages#5787)
2024-01-03 stuartmorgan@google.com [google_sign_in] Correct clearAuthCache declarations (flutter/packages#5693)
2024-01-03 15619084+vashworth@users.noreply.github.com Unpin mac_toolchain version (flutter/packages#5683)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
goderbauer added a commit that referenced this pull request Jan 5, 2024
Follow-up to
#5717 (comment).

---------

Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
JSUYA added a commit to JSUYA/plugins that referenced this pull request Mar 6, 2024
Some packages require package upgrade rather than simple modification
(ex: google_maps_flutter) Therefore, the rules below are temporarily ignored.
Any necessary modifications can be applied in a later PR.

flutter/packages#4060
- unnecessary_null_comparison

flutter/packages#4067
- unawaited_futures

flutter/packages#5717
- dangling_library_doc_comments
- no_literal_bool_comparisons
- unnecessary_library_directive
- use_colored_box
- use_enums
- use_string_in_part_of_directives
zhouyuanbo pushed a commit to zhouyuanbo/video_player_platform_interface_6.2.2 that referenced this pull request May 24, 2024
Follow-up to
flutter/packages#5717 (comment).

---------

Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Applying the latest analysis_options.yaml from flutter/flutter to this
repo. Most fixes were auto-generated by `dart fix`.
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…ter#5793)

Follow-up to
flutter#5717 (comment).

---------

Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.