[in_app_purchase] Add play country code api #5941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config test to return map not object
gmackall
reviewed
Jan 26, 2024
...se_android/android/src/main/java/io/flutter/plugins/inapppurchase/MethodCallHandlerImpl.java
Outdated
Show resolved
Hide resolved
| /// See: https://developer.android.com/reference/com/android/billingclient/api/BillingConfig | ||
| /// See: https://unicode.org/cldr/charts/latest/supplemental/territory_containment_un_m_49.html | ||
| Future<String> getBillingConfig() async { | ||
| return _billingClientManager.runWithClientNonRetryable( |
Member
There was a problem hiding this comment.
Should this return a BillingConfigWrapper and then be also be retryable, as it returns a subclass of HasBillingResponse?
Contributor
Author
There was a problem hiding this comment.
I wanted to keep the exposed api as small as possible so I thought the country code was the right level to expose. I didnt even think about if it should be retryable I just mirrored the other commands. Let me look at what that does and make a call.
Member
There was a problem hiding this comment.
I think this comment still applies
…ain/java/io/flutter/plugins/inapppurchase/MethodCallHandlerImpl.java Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
…i to getCountryCode
Contributor
Author
|
Without a correctly setup play store billing setup I was able to manually verify that I could get the country code of my personal account. I have not verified an account in a different country but the defaults are all empty string so I think that is a reasonable validation. |
…le leaving instructions for how to test
Contributor
Author
|
Fixing readme validation that failed on previous content. |
reidbaker
added
the
override: no changelog needed
mossmana
reviewed
Jan 30, 2024
...purchase/in_app_purchase_android/lib/src/billing_client_wrappers/billing_client_wrapper.dart
Show resolved
Hide resolved
gmackall
reviewed
Jan 30, 2024
| /// See: https://developer.android.com/reference/com/android/billingclient/api/BillingConfig | ||
| /// See: https://unicode.org/cldr/charts/latest/supplemental/territory_containment_un_m_49.html | ||
| Future<String> getBillingConfig() async { | ||
| return _billingClientManager.runWithClientNonRetryable( |
Member
There was a problem hiding this comment.
I think this comment still applies
..._app_purchase/in_app_purchase_android/lib/src/in_app_purchase_android_platform_addition.dart
Show resolved
Hide resolved
jmagman
reviewed
Jan 30, 2024
packages/in_app_purchase/in_app_purchase_storekit/example/README.md
Outdated
Show resolved
Hide resolved
packages/in_app_purchase/in_app_purchase_storekit/example/README.md
Outdated
Show resolved
Hide resolved
gmackall
approved these changes
Jan 30, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
LGTM outside of the format/analyze failures!
reidbaker
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2024
flutter/packages@5b48c44...d37fb0a 2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/packages#6033) 2024-02-01 32242716+ricardoamador@users.noreply.github.com Update the emulator versions and expose cipd. (flutter/packages#6025) 2024-02-01 stuartmorgan@google.com [tool] Add details to missing gradle coverage error (flutter/packages#6029) 2024-02-01 stuartmorgan@google.com [file_selector] Fix comment typo (flutter/packages#6027) 2024-02-01 43054281+camsim99@users.noreply.github.com [camerax] Change `buildPreview` to return `Texture` versus `FutureBuilder` (flutter/packages#6021) 2024-02-01 engine-flutter-autoroll@skia.org Manual roll Flutter from c65ab4d to e02e207 (38 revisions) (flutter/packages#6028) 2024-02-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 75a2e5b to c65ab4d (22 revisions) (flutter/packages#6026) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter from ace9181 to 75a2e5b (16 revisions) (flutter/packages#6017) 2024-02-01 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (flutter/packages#5727) 2024-01-31 stuartmorgan@google.com [tool] Extend `flutter test` workaround to other desktops (flutter/packages#6024) 2024-01-31 katelovett@google.com [two_dimensional_scrollables] Merged cells for TableView (flutter/packages#5917) 2024-01-31 tessertaha@gmail.com [rfw] Restore RFW to 100% coverage after `ButtonBar` update (flutter/packages#6020) 2024-01-31 louisehsu@google.com [in_app_purchase] Convert storefront(), transactions(), canMakePayment(), and addPayment() to pigeon (flutter/packages#5910) 2024-01-31 reidbaker@google.com [in_app_purchase] Add play country code api (flutter/packages#5941) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter/issues/141627
Hold merging on:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).