[video_player] Update iOS/macOS to Pigeon 13 #5270
Conversation
| } | ||
|
|
||
| - (void)seekTo:(int)location completionHandler:(void (^)(BOOL))completionHandler { | ||
| - (void)seekTo:(int64_t)location completionHandler:(void (^)(BOOL))completionHandler { |
There was a problem hiding this comment.
We were calling this with input.position.intValue previously, which when I removed intValue to adjust for the lack of boxing turned into a warning about loss of precision passing an NSInteger as an int. But this is just used for CMTimeMake, which takes an int64_t, so it was better to change this type than to pointless cast at the call site and (in theory, but probably never in practice) truncate the value.
| objcHeaderOut: 'ios/Classes/messages.g.h', | ||
| objcSourceOut: 'ios/Classes/messages.g.m', | ||
| objcHeaderOut: 'darwin/Classes/messages.g.h', | ||
| objcSourceOut: 'darwin/Classes/messages.g.m', |
There was a problem hiding this comment.
I missed this when I move the files to add macOS support.
| player.eventChannel = eventChannel; | ||
| self.playersByTextureId[@(textureId)] = player; | ||
| FVPTextureMessage *result = [FVPTextureMessage makeWithTextureId:@(textureId)]; | ||
| FVPTextureMessage *result = [FVPTextureMessage makeWithTextureId:textureId]; |
There was a problem hiding this comment.
is it pigeon's change? the new pigeon supports primitives and the old version does not?
There was a problem hiding this comment.
Yes, I changed Pigeon's Obj-C generator to stop boxing non-nullable values, to make its generated code more idiomatic and less error-prone (given that it turns out Xcode is less reliable about warning for buggy implicit NSNumber*->BOOL conversions than I thought).
stuartmorgan-g
added
the
autosubmit
| @@ -1,3 +1,7 @@ | |||
| ## 2.5.1 | |||
|
|
|||
| * Updates to Pigeon 13. | |||
There was a problem hiding this comment.
nit ' ' -> ' '.
I can't believe this got merged... /s
There was a problem hiding this comment.
Doh! Luckily it shouldn't show up that way on pub.dev.
flutter/packages@c9fec61...6ad40b9 2023-11-01 engine-flutter-autoroll@skia.org Roll Flutter from e12d1a7 to 29b2516 (34 revisions) (flutter/packages#5290) 2023-11-01 stuartmorgan@google.com [file_selector] Updates iOS to Pigeon 13 (flutter/packages#5268) 2023-10-31 github@alexv525.com [camera_avfoundation] � Fix inverted orientation strings (flutter/packages#5261) 2023-10-31 43054281+camsim99@users.noreply.github.com [tool] Add option for Android compile SDK version to update-dependencies command (flutter/packages#5010) 2023-10-31 stuartmorgan@google.com [video_player] Update iOS/macOS to Pigeon 13 (flutter/packages#5270) 2023-10-31 tessertaha@gmail.com [video_player] Update example app to replace `ButtonBar` with `OverflowBar` (flutter/packages#5274) 2023-10-31 stuartmorgan@google.com [image_picker] Update iOS to Pigeon 13 (flutter/packages#5266) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Picks up several breaking changes, including the switch to unwrapped BOOL properties.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).