[image_picker] Update iOS to Pigeon 13 #5266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
commented
Oct 30, 2023
| SourceSpecification(this.type, this.camera); | ||
| SourceType type; | ||
| SourceCamera? camera; | ||
| SourceCamera camera; |
Collaborator
Author
There was a problem hiding this comment.
I was going to update the code receiving this to handle the new boxed value, but realized that we would never actually send null so it was much easier to just fix the spec.
tarrinneal
approved these changes
Oct 31, 2023
stuartmorgan-g
added
the
autosubmit
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 1, 2023
flutter/packages@c9fec61...6ad40b9 2023-11-01 engine-flutter-autoroll@skia.org Roll Flutter from e12d1a7 to 29b2516 (34 revisions) (flutter/packages#5290) 2023-11-01 stuartmorgan@google.com [file_selector] Updates iOS to Pigeon 13 (flutter/packages#5268) 2023-10-31 github@alexv525.com [camera_avfoundation] � Fix inverted orientation strings (flutter/packages#5261) 2023-10-31 43054281+camsim99@users.noreply.github.com [tool] Add option for Android compile SDK version to update-dependencies command (flutter/packages#5010) 2023-10-31 stuartmorgan@google.com [video_player] Update iOS/macOS to Pigeon 13 (flutter/packages#5270) 2023-10-31 tessertaha@gmail.com [video_player] Update example app to replace `ButtonBar` with `OverflowBar` (flutter/packages#5274) 2023-10-31 stuartmorgan@google.com [image_picker] Update iOS to Pigeon 13 (flutter/packages#5266) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up some breaking changes in the Objective-C generator, most notably a switch from
NSNumber*toBOOLfor non-nullable boolean values, which avoids the class of problem noticed in #5194Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).