Revert Versions API

[iskakaushik]

No description provided.

[cbracken]

@iskakaushik did you have any plans to rebase and land this? If not, could you close the PR?

I'd be interested in further discussing the objections to this API before we revert.

[iskakaushik]

@cbracken , I do plan on rebasing and landing this PR.

The use cases for having this so far have been:

1. Make sure we upload the right version of artifact. Proposed solution: grep for the string in the binary.
2. Have a way for Crashlytics or other apps to display the version info. Proposed solution: What they really need is the framework version, not the engine/skia/dart versions. Framework version is not exposed by this PR, so reverting this should be ok.

Let me know if you think reverting this is still a bad idea.

cc: @dnfield , @Hixie , @chinmaygarde

[chinmaygarde]

Code looks good to me but I have no opinions about exposing this API to Dart code. You should probably discuss this with one of the stakeholders to check if the original reasons for this revert still hold.

[cbracken]

Alright; discussed with @Hixie. The original goal here was for us to have a mechanism that allows us to ensure the uploaded engine version in cloud storage/downloaded by the tool matches the version we expect. We can do that without exposing API in the same way that e.g. Dart embeds SNAPSHOT_HASH in both the VM and in snapshots.