This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Android Embedding PR29: Improve FlutterFragment construction API + engine config API. #8540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Embedding PR29: Improve FlutterFragment construction API + engine config API.
I accidentally removed the ability to override a
FlutterFragment
method for engine customization in a previous PR. I bring that ability back with this PR.I also revamped the
Builder
withinFlutterFragment
such thatFlutterFragment.Builder
can be used directly forFlutterFragment
subclasses without itself being subclassed, so long as the subclass does not need to introduce any new properties:If the
FlutterFragment
subclass does need to add more creation properties then theBuilder
can be subclassed as before. Then it can be used like:If a typical
FlutterFragment
is desired, then theBuilder
can be used as it previously was: