Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert Versions API #7828

Merged
merged 5 commits into from
Apr 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ci/licenses_golden/licenses_flutter
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ FILE: ../../../flutter/common/settings.cc
FILE: ../../../flutter/common/settings.h
FILE: ../../../flutter/common/task_runners.cc
FILE: ../../../flutter/common/task_runners.h
FILE: ../../../flutter/common/version/version.cc
FILE: ../../../flutter/common/version/version.h
FILE: ../../../flutter/flow/compositor_context.cc
FILE: ../../../flutter/flow/compositor_context.h
FILE: ../../../flutter/flow/debug_print.cc
Expand Down Expand Up @@ -360,9 +358,6 @@ FILE: ../../../flutter/lib/ui/text/text_box.h
FILE: ../../../flutter/lib/ui/ui.dart
FILE: ../../../flutter/lib/ui/ui_dart_state.cc
FILE: ../../../flutter/lib/ui/ui_dart_state.h
FILE: ../../../flutter/lib/ui/versions.cc
FILE: ../../../flutter/lib/ui/versions.dart
FILE: ../../../flutter/lib/ui/versions.h
FILE: ../../../flutter/lib/ui/window.dart
FILE: ../../../flutter/lib/ui/window/platform_message.cc
FILE: ../../../flutter/lib/ui/window/platform_message.h
Expand Down Expand Up @@ -720,6 +715,8 @@ FILE: ../../../flutter/shell/platform/glfw/keyboard_hook_handler.h
FILE: ../../../flutter/shell/platform/glfw/public/flutter_glfw.h
FILE: ../../../flutter/shell/platform/glfw/text_input_plugin.cc
FILE: ../../../flutter/shell/platform/glfw/text_input_plugin.h
FILE: ../../../flutter/shell/version/version.cc
FILE: ../../../flutter/shell/version/version.h
FILE: ../../../flutter/sky/packages/flutter_services/lib/empty.dart
FILE: ../../../flutter/sky/tools/roll/patches/chromium/android_build.patch
FILE: ../../../flutter/third_party/txt/src/txt/platform.cc
Expand Down
3 changes: 0 additions & 3 deletions lib/ui/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ source_set("ui") {
"text/text_box.h",
"ui_dart_state.cc",
"ui_dart_state.h",
"versions.cc",
"versions.h",
"window/platform_message.cc",
"window/platform_message.h",
"window/platform_message_response.cc",
Expand All @@ -104,7 +102,6 @@ source_set("ui") {
deps = [
"$flutter_root/assets",
"$flutter_root/common",
"$flutter_root/common/version",
"$flutter_root/flow",
"$flutter_root/fml",
"$flutter_root/runtime:test_font",
Expand Down
2 changes: 0 additions & 2 deletions lib/ui/dart_ui.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
#include "flutter/lib/ui/text/font_collection.h"
#include "flutter/lib/ui/text/paragraph.h"
#include "flutter/lib/ui/text/paragraph_builder.h"
#include "flutter/lib/ui/versions.h"
#include "flutter/lib/ui/window/window.h"
#include "third_party/tonic/converter/dart_converter.h"
#include "third_party/tonic/logging/dart_error.h"
Expand Down Expand Up @@ -91,7 +90,6 @@ void DartUI::InitForGlobal() {
SceneBuilder::RegisterNatives(g_natives);
SemanticsUpdate::RegisterNatives(g_natives);
SemanticsUpdateBuilder::RegisterNatives(g_natives);
Versions::RegisterNatives(g_natives);
Vertices::RegisterNatives(g_natives);
Window::RegisterNatives(g_natives);
#if defined(OS_FUCHSIA)
Expand Down
1 change: 0 additions & 1 deletion lib/ui/dart_ui.gni
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ dart_ui_files = [
"$flutter_root/lib/ui/semantics.dart",
"$flutter_root/lib/ui/text.dart",
"$flutter_root/lib/ui/ui.dart",
"$flutter_root/lib/ui/versions.dart",
"$flutter_root/lib/ui/window.dart",
]

Expand Down
1 change: 0 additions & 1 deletion lib/ui/ui.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,4 @@ part 'plugins.dart';
part 'pointer.dart';
part 'semantics.dart';
part 'text.dart';
part 'versions.dart';
part 'window.dart';
31 changes: 0 additions & 31 deletions lib/ui/versions.cc

This file was deleted.

37 changes: 0 additions & 37 deletions lib/ui/versions.dart

This file was deleted.

21 changes: 0 additions & 21 deletions lib/ui/versions.h

This file was deleted.

2 changes: 1 addition & 1 deletion shell/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ source_set("common") {
]

public_deps = [
"$flutter_root/common/version",
"$flutter_root/shell/version",
"$flutter_root/third_party/txt",
"//third_party/rapidjson",
"//third_party/tonic",
Expand Down
1 change: 0 additions & 1 deletion shell/common/engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <vector>

#include "flutter/common/settings.h"
#include "flutter/common/version/version.h"
#include "flutter/fml/eintr_wrapper.h"
#include "flutter/fml/file.h"
#include "flutter/fml/make_copyable.h"
Expand Down
2 changes: 1 addition & 1 deletion shell/common/persistent_cache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
#include <memory>
#include <string>

#include "flutter/common/version/version.h"
#include "flutter/fml/base32.h"
#include "flutter/fml/file.h"
#include "flutter/fml/make_copyable.h"
#include "flutter/fml/mapping.h"
#include "flutter/fml/paths.h"
#include "flutter/fml/trace_event.h"
#include "flutter/shell/version/version.h"

namespace flutter {

Expand Down
2 changes: 1 addition & 1 deletion shell/common/switches.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
#include <sstream>
#include <string>

#include "flutter/common/version/version.h"
#include "flutter/fml/native_library.h"
#include "flutter/fml/paths.h"
#include "flutter/fml/string_view.h"
#include "flutter/shell/version/version.h"

// Include once for the default enum definition.
#include "flutter/shell/common/switches.h"
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion common/version/version.cc → shell/version/version.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "flutter/common/version/version.h"
#include "flutter/shell/version/version.h"

namespace flutter {

Expand Down
File renamed without changes.
6 changes: 3 additions & 3 deletions common/version/version.h → shell/version/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef FLUTTER_COMMON_VERSION_VERSION_H_
#define FLUTTER_COMMON_VERSION_VERSION_H_
#ifndef FLUTTER_SHELL_COMMON_VERSION_H_
#define FLUTTER_SHELL_COMMON_VERSION_H_

namespace flutter {

Expand All @@ -15,4 +15,4 @@ const char* GetDartVersion();

} // namespace flutter

#endif // FLUTTER_COMMON_VERSION_VERSION_H_
#endif // FLUTTER_SHELL_COMMON_VERSION_H_
32 changes: 0 additions & 32 deletions testing/dart/versions_test.dart

This file was deleted.