This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 #6097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Aug 27, 2018
Member
|
|
chinmaygarde
approved these changes
Aug 27, 2018
The reduces the ICU data file even more:
Uncompressed size: 883,280B (862.6 KB), minus 363.2KB
Compressed size: 460,972B (450.2KB), minus 83.9KB
The following unused resources are removed comapred to previous version:
* uts46.nrm
* nfkc_cf.nrm
* cnvalias.icu
* Break Iterators for:
* Sentence breaks
* Title breaks
* CSS-specific line breaks ("regular" line breaks are still supported)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2018
flutter/engine@af42b6d...06b8fa4 git log af42b6d..06b8fa4 --no-merges --oneline 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2018
flutter/engine@af42b6d...eb97386 git log af42b6d..eb97386 --no-merges --oneline eb97386 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100) 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2018
flutter/engine@af42b6d...f05b08b git log af42b6d..f05b08b --no-merges --oneline f05b08b Roll src/third_party/skia f125111ca733..7ba1d64f0706 (18 commits) (flutter/engine#6102) eb97386 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100) 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2018
flutter/engine@af42b6d...56bad48 git log af42b6d..56bad48 --no-merges --oneline 56bad48 expose bold text flag in accessibility features for iOS (flutter/engine#6072) ad4e87d Convert synthesized Android motion events to long and not to int. (flutter/engine#6103) f05b08b Roll src/third_party/skia f125111ca733..7ba1d64f0706 (18 commits) (flutter/engine#6102) eb97386 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100) 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 28, 2018
flutter/engine@af42b6d...56bad48 git log af42b6d..56bad48 --no-merges --oneline 56bad48 expose bold text flag in accessibility features for iOS (flutter/engine#6072) ad4e87d Convert synthesized Android motion events to long and not to int. (flutter/engine#6103) f05b08b Roll src/third_party/skia f125111ca733..7ba1d64f0706 (18 commits) (flutter/engine#6102) eb97386 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100) 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 14, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. Previous update was here: flutter#6097 I was advised to upgrade in the code revie for this PR: flutter#13045 This change brings in the icu::Locale::forLanguageTag(...) function which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers)
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 14, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. Previous update was here: flutter#6097 I was advised to upgrade in the code revie for this PR: flutter#13045 This change brings in the icu::Locale::forLanguageTag(...) function which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers)
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 14, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code revie for this PR: flutter#13045 This change brings in the icu::Locale::forLanguageTag(...) function which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers) Tested: ```bash #!/bin/bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 14, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers) Tested: ```bash #!/bin/bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers) Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers) Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers) Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers) Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers) Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
filmil
added a commit
to filmil/engine
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
chinmaygarde
pushed a commit
that referenced
this pull request
Oct 15, 2019
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: #6097 I was advised to upgrade in the code review for this PR: #13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reduces the ICU data file even more:
Uncompressed size: 883,280B (862.6 KB), minus 363.2KB
Compressed size: 460,972B (450.2KB), minus 83.9KB
The following unused resources are removed compared to the previous version: