Skip to content

Commit ec33f02

Browse files
committed
Upgrades the ICU version to 64.2
The current version is 62.1, which is a now 3 major releases behind, given that ICU 65 was released on Oct 3, 2019. The version bump required an update to buildroot to fix too strict compilation of ICU. Previous update was here: flutter#6097 I was advised to upgrade in the code review for this PR: flutter#13045 This change brings in the function `icu::Locale::forLanguageTag(...)` which is directly relevant to the work in the PR, but also updates the library considerably. * TODO(filmil): Release notes (will work with reviewers) Tested: ```bash set -x readonly FLUTTER_ENGINE_DIR="${FLUTTER_ENGINE_DIR:-$HOME/fx/flutter/engine/src}" readonly OUT_DIR="${FLUTTER_ENGINE_DIR}/out" ( cd ${FLUTTER_ENGINE_DIR} ./flutter/tools/gn --unoptimized ninja -j 100 -C "${OUT_DIR}/host_debug_unopt" ./flutter/testing/run_tests.py --type engine ) ```
1 parent c2f1b09 commit ec33f02

File tree

3 files changed

+366
-163
lines changed

3 files changed

+366
-163
lines changed

DEPS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ allowed_hosts = [
136136
]
137137

138138
deps = {
139-
'src': 'https://github.com/flutter/buildroot.git' + '@' + 'edd0f2d19604a7d63deb20e9c19c1412acb8a9bd',
139+
'src': 'https://github.com/flutter/buildroot.git' + '@' + '9c893948fd2413b32669b5a9261a1b6a487b8f9b',
140140

141141
# Fuchsia compatibility
142142
#
@@ -177,7 +177,7 @@ deps = {
177177
Var('chromium_git') + '/chromium/src/ios.git' + '@' + Var('ios_tools_revision'),
178178

179179
'src/third_party/icu':
180-
Var('chromium_git') + '/chromium/deps/icu.git' + '@' + 'c56c671998902fcc4fc9ace88c83daa99f980793',
180+
Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '5005010d694e16571b8dfbf07d70817841f80a69',
181181

182182
'src/third_party/boringssl':
183183
Var('github_git') + '/dart-lang/boringssl_gen.git' + '@' + Var('dart_boringssl_gen_rev'),

ci/licenses_golden/licenses_fuchsia

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Signature: 2b67dee2e67cdd9a808ae7f3904ab47b
1+
Signature:99eb0b490efdb11c68339e5113921d34
22

33
UNUSED LICENSES:
44

@@ -1396,8 +1396,6 @@ FILE: ../../../fuchsia/sdk/linux/fidl/fuchsia.wlan.service/meta.json
13961396
FILE: ../../../fuchsia/sdk/linux/fidl/fuchsia.wlan.stats/meta.json
13971397
FILE: ../../../fuchsia/sdk/linux/pkg/async-cpp/executor.cc
13981398
FILE: ../../../fuchsia/sdk/linux/pkg/async-cpp/include/lib/async/cpp/executor.h
1399-
FILE: ../../../fuchsia/sdk/linux/pkg/async-cpp/include/lib/async/cpp/irq.h
1400-
FILE: ../../../fuchsia/sdk/linux/pkg/async-cpp/irq.cc
14011399
FILE: ../../../fuchsia/sdk/linux/pkg/async-cpp/meta.json
14021400
FILE: ../../../fuchsia/sdk/linux/pkg/async-default/meta.json
14031401
FILE: ../../../fuchsia/sdk/linux/pkg/async-loop-cpp/meta.json
@@ -2805,7 +2803,6 @@ FILE: ../../../fuchsia/sdk/linux/pkg/async-loop/loop.c
28052803
FILE: ../../../fuchsia/sdk/linux/pkg/async-testing/dispatcher_stub.cc
28062804
FILE: ../../../fuchsia/sdk/linux/pkg/async-testing/include/lib/async-testing/dispatcher_stub.h
28072805
FILE: ../../../fuchsia/sdk/linux/pkg/async/include/lib/async/dispatcher.h
2808-
FILE: ../../../fuchsia/sdk/linux/pkg/async/include/lib/async/irq.h
28092806
FILE: ../../../fuchsia/sdk/linux/pkg/async/include/lib/async/receiver.h
28102807
FILE: ../../../fuchsia/sdk/linux/pkg/async/include/lib/async/task.h
28112808
FILE: ../../../fuchsia/sdk/linux/pkg/async/include/lib/async/wait.h

0 commit comments

Comments
 (0)