This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Unconditionally set resource id to empty string #6096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Aug 27, 2018
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
We should still file a bug with the TalkBack team.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2018
flutter/engine@af42b6d...06b8fa4 git log af42b6d..06b8fa4 --no-merges --oneline 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2018
flutter/engine@af42b6d...eb97386 git log af42b6d..eb97386 --no-merges --oneline eb97386 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100) 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2018
flutter/engine@af42b6d...f05b08b git log af42b6d..f05b08b --no-merges --oneline f05b08b Roll src/third_party/skia f125111ca733..7ba1d64f0706 (18 commits) (flutter/engine#6102) eb97386 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100) 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2018
flutter/engine@af42b6d...56bad48 git log af42b6d..56bad48 --no-merges --oneline 56bad48 expose bold text flag in accessibility features for iOS (flutter/engine#6072) ad4e87d Convert synthesized Android motion events to long and not to int. (flutter/engine#6103) f05b08b Roll src/third_party/skia f125111ca733..7ba1d64f0706 (18 commits) (flutter/engine#6102) eb97386 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100) 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 28, 2018
flutter/engine@af42b6d...56bad48 git log af42b6d..56bad48 --no-merges --oneline 56bad48 expose bold text flag in accessibility features for iOS (flutter/engine#6072) ad4e87d Convert synthesized Android motion events to long and not to int. (flutter/engine#6103) f05b08b Roll src/third_party/skia f125111ca733..7ba1d64f0706 (18 commits) (flutter/engine#6102) eb97386 Roll src/third_party/skia 0fdc53f9ffc6..f125111ca733 (10 commits) (flutter/engine#6100) 06b8fa4 Roll src/third_party/skia dd04bec39cea..0fdc53f9ffc6 (13 commits) (flutter/engine#6098) bf07804 Roll ICU to c56c671998902fcc4fc9ace88c83daa99f980793 (flutter/engine#6097) c867305 Unconditionally set resource id to empty string (flutter/engine#6096) b4b1d05 Roll src/third_party/skia e00fe30b8fe7..dd04bec39cea (4 commits) (flutter/engine#6095) 8694036 Roll src/third_party/skia 420696961c8c..e00fe30b8fe7 (1 commits) (flutter/engine#6094) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer talkback versions attempt to check if the accessibility node comes from the PIN screen, resulting in an NPE when there is no resource Id set. This causes flutter/flutter#21030
Fixes flutter/flutter#21030